Skip to content

Remove redundant default version code #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021
Merged

Remove redundant default version code #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ author: "Arduino"
inputs:
version:
description: "Version to use. Example: 3.4.2"
required: false
required: true
default: "3.x"
repo-token:
description: "Token with permissions to do repo things"
Expand Down
9 changes: 2 additions & 7 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,14 +266,9 @@ const installer = __importStar(__nccwpck_require__(1480));
function run() {
return __awaiter(this, void 0, void 0, function* () {
try {
let version = core.getInput("version");
const version = core.getInput("version", { required: true });
const repoToken = core.getInput("repo-token");
if (!version) {
version = "2.x";
}
if (version) {
yield installer.getTask(version, repoToken);
}
yield installer.getTask(version, repoToken);
}
catch (error) {
core.setFailed(error.message);
Expand Down
9 changes: 2 additions & 7 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,10 @@ import * as installer from "./installer";

async function run() {
try {
let version = core.getInput("version");
const version = core.getInput("version", { required: true });
const repoToken = core.getInput("repo-token");
if (!version) {
version = "2.x";
}

if (version) {
await installer.getTask(version, repoToken);
}
await installer.getTask(version, repoToken);
} catch (error) {
core.setFailed(error.message);
}
Expand Down