Changed _next_read_ms to _last_read_ms to prevent millis() rollover #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Upon inspection of the source code, I saw you were checking if the tag was still near by setting
_next_read_msto a future value. This is not a good approach sincemillis()overflows every 50 days. The appropriate approach is to mark a previous millis and compare with the current value, as shown on this StackOverflow answer and also used on the BlinkWithoutDelay Arduino example.So what I did was change
_next_read_msto_last_read_msand updateis_tag_near()to see ifmillis() - _last_read_ms < RDM6300_NEXT_READ_MS.