Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1094): remove computed record fields returned in API results #1095

Merged
merged 3 commits into from Feb 7, 2022

Conversation

frascuchon
Copy link
Member

Work done In this PR will simplify work in #945.

Closes #1094

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1095 (54c00ca) into master (fd6dc99) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         119      119           
  Lines        4482     4482           
=======================================
  Hits         4257     4257           
  Misses        225      225           
Flag Coverage Δ
pytest 94.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...brix/server/tasks/text_classification/api/model.py 99.42% <100.00%> (+<0.01%) ⬆️
...rix/server/tasks/token_classification/api/model.py 98.72% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e449e1...54c00ca. Read the comment docs.

@frascuchon frascuchon merged commit e0e9a67 into master Feb 7, 2022
@frascuchon frascuchon deleted the bugfixes/api-return-wrong-data-model branch February 7, 2022 10:10
@frascuchon frascuchon added this to In progress in Release via automation Feb 7, 2022
@frascuchon frascuchon moved this from In progress to Done in Release Feb 7, 2022
@frascuchon frascuchon moved this from Done to Ready to DEV QA in Release Feb 7, 2022
@frascuchon frascuchon removed this from Ready to DEV QA in Release Feb 7, 2022
frascuchon added a commit that referenced this pull request Feb 7, 2022
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

(cherry picked from commit e0e9a67)
frascuchon added a commit that referenced this pull request Feb 7, 2022
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

* fix: return empty list for no predicted_as

* test: add tests

(cherry picked from commit 78c03ea)

(cherry picked from commit e0e9a67)
frascuchon added a commit that referenced this pull request Feb 7, 2022
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

* fix: return empty list for no predicted_as

* test: add tests

(cherry picked from commit 78c03ea)

(cherry picked from commit e0e9a67)
frascuchon added a commit that referenced this pull request Feb 10, 2022
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

* fix: return empty list for no predicted_as

* test: add tests

(cherry picked from commit 78c03ea)

(cherry picked from commit e0e9a67)
dvsrepo added a commit that referenced this pull request Feb 10, 2022
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API search] records data model returns extra fields
2 participants