Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#945): add current search aggregations as metrics #1115

Merged
merged 4 commits into from Feb 9, 2022

Conversation

frascuchon
Copy link
Member

This PR define missing current aggregation in search as dataset metrics. For example we can find predicted_as or annotated_by as a metric for token classification datasets.

This is a part of work for better search model interaction

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1115 (e4c9dfc) into master (bd37a1f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   94.98%   95.01%   +0.02%     
==========================================
  Files         119      119              
  Lines        4491     4512      +21     
==========================================
+ Hits         4266     4287      +21     
  Misses        225      225              
Flag Coverage Δ
pytest 95.01% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/commons/es_helpers.py 86.99% <ø> (ø)
src/rubrix/server/tasks/commons/metrics/commons.py 100.00% <ø> (ø)
...rubrix/server/tasks/text_classification/metrics.py 100.00% <ø> (ø)
src/rubrix/server/commons/es_wrapper.py 88.28% <100.00%> (ø)
src/rubrix/server/tasks/commons/dao/dao.py 98.46% <100.00%> (+0.04%) ⬆️
.../rubrix/server/tasks/commons/metrics/model/base.py 96.66% <100.00%> (+0.61%) ⬆️
src/rubrix/server/tasks/commons/metrics/service.py 98.21% <100.00%> (ø)
...ubrix/server/tasks/token_classification/metrics.py 99.35% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d422d5c...e4c9dfc. Read the comment docs.

Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@frascuchon frascuchon merged commit e63878b into master Feb 9, 2022
@frascuchon frascuchon deleted the refactor/add-missing-metrics branch February 9, 2022 14:23
@frascuchon frascuchon linked an issue Feb 9, 2022 that may be closed by this pull request
frascuchon added a commit that referenced this pull request Feb 10, 2022
* feat: add more commons metrics

* fix: set defaults for optional fields

* feat: add metrics for text and token classification

* test: update tests

(cherry picked from commit e63878b)
dvsrepo added a commit that referenced this pull request Feb 10, 2022
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search] Improve and normalizes the search data model
2 participants