Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#945): validate label for single label text classification dataset #1123

Merged

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Feb 10, 2022

This PR fixes record prediction validation for single label text classification

Closes #1118
Fixes changes applied in #1075

fix #1118

This PR fixes record prediction validation for single label text classification
@frascuchon frascuchon changed the title fix(#1118): validate label for single label text classification dataset fix(#945): validate label for single label text classification dataset Feb 10, 2022
@frascuchon frascuchon merged commit eaa641c into master Feb 10, 2022
@frascuchon frascuchon deleted the fix/validate_text_classifier_single_label_prediction branch February 10, 2022 11:16
frascuchon pushed a commit that referenced this pull request Feb 10, 2022
* refactor: add text search field for text class datasets

* refactor: separate db and results extra fields

* refactor: us db model adding records

* chore: update sdk model for token classification (deprecated raw_text field)

* refactor(UI): use new text field for token classification with backward compatibility

* test: update tests

* Update TextClassification.js

* fix: wrong merge conflicts

(cherry picked from commit 515a766)

fix: include default aggregations for text2text (#1097)

* fix(text2text): return all common aggregations

* test: add tests

* fix: better score aggrs using keyed resuls

* test: add missing tests

* test: skip score checks

(cherry picked from commit e931543)

* revert: include js specs (#1075)

fix(#945): validate label for single label text classification dataset (#1123)

* fix(#945): validate label for single label text classification dataset

Closes #1118
Fixes changes applied in #1075

This PR fixes record prediction validation for single label text classification

* Revert "fix(#1118): validate label for single label text classification dataset"

This reverts commit 736c638.

* fix: compute predicted_as properly

* test: add specs

Co-authored-by: Francisco Aranda <francisco@recogn.ai>
(cherry picked from commit eaa641c)
dvsrepo added a commit that referenced this pull request Feb 10, 2022
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Annotation] Validate label for single label text classification dataset raise an error
2 participants