Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NER Fine tuning] content selection #1063

Closed
12 tasks done
Amelie-V opened this issue Jan 31, 2022 · 13 comments · Fixed by #1084 or #1163
Closed
12 tasks done

[NER Fine tuning] content selection #1063

Amelie-V opened this issue Jan 31, 2022 · 13 comments · Fixed by #1084 or #1163
Assignees
Projects

Comments

@Amelie-V
Copy link
Member

Amelie-V commented Jan 31, 2022

Multi word

Actual state : (VIEW SS)
1- I select various words, highlight is grey and in a solid block (Highlight/words).
2- When selection is done, highlight selection is splited and label selector appears.

  • Should be:

1- I select various words, highlight is grey and splited (highlight/word)
2- When selection is done, highlight selection is a solid block label selector appears.

Delete labelling

  • Make clicable the whole tooltip to delete

Selection on a searched word

  • Selection highlight should not be cut (SS)
  • When selection is containing a search word the label selector does not appear (how it works only on right>left sense)
  • In general : change appearance of results : in place of Orange highlight show text in bold

Cursor

  • Active "hand" cursor (pointer) on piece of text already annotated/Predicted
  • Active "Text Select" cursor on the rest of record
  • Enlarge the hover state to the whole area : (record + annotated tooltip + empty space between them) (record + predicted tooltip + empty space between us)

New Select label modal

  • Integrate new UI modal
  • In case of unique label, dont show modal, and just affect label after selecting text
  • Add logic to show first and preselected the last label used
  • Add following Keyboard shortcut: Enter to valid preselected label, and vertical arrow keyboard or Number to valid other labels
@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-01-31 a las 14 32 38

Captura de pantalla 2022-01-31 a las 14 32 20

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-01-31 a las 14 52 30

@Amelie-V Amelie-V assigned Amelie-V and leiyre and unassigned Amelie-V Jan 31, 2022
@Amelie-V Amelie-V added this to Backlog in Release via automation Jan 31, 2022
leiyre pushed a commit that referenced this issue Feb 2, 2022
closes #1063
This PR adds new UI, improves content selection in Token Classifier, improves styles and shortcut for annotation
@frascuchon frascuchon moved this from Backlog to In progress in Release Feb 7, 2022
@frascuchon
Copy link
Member

frascuchon commented Feb 7, 2022

Regarding interactions in app, I think it would be nice a way to easily validate a single annotation (entity label in record)

Screenshot 2022-02-07 at 16 58 15

Screenshot 2022-02-07 at 16 58 35

The example below shows a predicted PERSON, where we must navigate over all entities finding predicted one. Even more, by clicking the tooltip, we loose the single annotation, that is a bit confusing.

What do you think @Amelie-V ?

Release automation moved this from In progress to Done Feb 8, 2022
frascuchon pushed a commit that referenced this issue Feb 8, 2022
This PR adds new UI, improves content selection in Token Classifier, improves styles and shortcut for annotation

* prediction tooltip position

* show prediction style when editing record

* dropdown styles

* short cut for selector

* remove origin property

* allow scroll dropdown

* prevent undefined element

* styles last selected whitespace

* dropdown scroll

* fix lint
@frascuchon frascuchon moved this from Done to Ready to DEV QA in Release Feb 8, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 8, 2022

QA 1

General

  • "Last label selected" shortcut is always [space]
  • [Enter] is the hover state when user is scrolling
  • "First label in alphabetic order is [1]
  • Continue to number label 9, 10, 11, 12 etc.
  • I would recommend to mark numbers label in the legend on top
  • Improve hover (see video)
  • Extend selector width
  • Extend padding around label buttons
  • Write shortcut [space];[1] in regular weight (not thin)
  • Center sector on highlighted selection

About Predicted text

  • On click on text with prediction text should be highlighted in grey

Proposal to speed up annotation on predicted text:

  • Activate selector at the same time, and show as dropdown first option the predicted label. Ej: Jerry is predicted as NAME, show NAME as first option.

  • Use the "pred. tooltip" to add a validation action. (UI required)

@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 8, 2022

Uploading NER_hover.mov…

@frascuchon
Copy link
Member

frascuchon commented Feb 8, 2022

  • Once last label is selected to be presented as the first one, sholdn't be duplicated.

Screenshot 2022-02-08 at 15 52 15

Screenshot 2022-02-08 at 15 53 22

  • Introduced highlighting design for text search does not highlight too much. Even more in other tasks:

Screenshot 2022-02-08 at 16 30 38

could we use another highlighting pattern ? maybe filling text with a higher contrast color ?

@frascuchon frascuchon reopened this Feb 8, 2022
Release automation moved this from Ready to DEV QA to In progress Feb 8, 2022
@dcfidalgo
Copy link
Contributor

@Amelie-V

  • To me, it seems a bit confusing that you can remove predictions:

    • a record with predictions in explore mode
    • go to annotation mode, validate only a few predictions in this record
    • go back to explore mode, the predictions are gone

    To me, predictions should be something static that you cannot change from within in web app. Use case: I have predictions from a model, and ask the client to annotate a few records to see how my model is performing. Right now, I cannot visually check this after the client annotated the dataset.

  • Like @frascuchon said, I also find it a bit counterintuitive that by clicking the prediction tooltip in the annotate mode, you remove the prediction (or is it the annotation in the end?).

  • annotate mode: when clicking on the mention predicted by the model, I would not display the dropdown but automatically choose the label predicted by the model. If you want to change the label, you can simply click again on the mention and choose the right label. As an alternative, I would put the predicted label first in the dropdown.

  • right now the workflow works nicely for models that are more or less working, but predictions from a model that makes a lot of mistakes, can get in your way quickly (you first have to remove all the wrong predictions, make your annotations and then press the save button). Then I would rather log the records again without the predictions to the web app. Not sure if two buttons could be a solution:

    • validate: validates the annotations that you explicitly made (by either making new annotations or validating single predictions)
    • validate all: validates all untouched predictions and your explicit annotations
  • general comment: when a record is pending, I really miss some "cancel" button next to the "save" button, but my understanding is that right now this is impossible to implement, right @leiyre?

leiyre pushed a commit that referenced this issue Feb 9, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 9, 2022

Annotation mode :

  • Maintain prediction state when label is annotated
  • Add delete all/clean button at record level in all states.
  • Add a Pre-annotation state in transparency by default.
  • Don't allow delete prediction.
  • Review Highlight

dvsrepo added a commit that referenced this issue Feb 10, 2022
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 11, 2022

Conclusion post Friday review:

Next release MVP:

  • Maintain prediction state (don't delete them)
  • Pre-annotation (can be deleted on clic)
  • Results searched: bold + color 4C4EA3
  • Dropdown: Add space between the label sugerency and the full list
  • Dropdown: color border is the darker label color
  • Maintain numeric until 9
  • DSont show num on legend (for now)
  • Label sugerency: when there is a prediction: the prediction, when no prediction the last used

V2:

  • Add Clear annotations bt
  • Add dropdown config.
  • Integrate new header (cross tasks)
  • prevent shortcut pagination when dropdown is active

@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 15, 2022

  • Background dropdown : use hover grey (in place of BG app color)
  • Lighter the color border
  • I would add the label number on the legend right now
  • scroll with arrow doesn't work Versión 98.0.4758.80 (Build oficial) (x86_64)
  • Legend : change "show all" for "+3"

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-02-15 a las 14 21 48
Captura de pantalla 2022-02-15 a las 14 21 09

leiyre pushed a commit that referenced this issue Feb 15, 2022
see #1063
This PR includes some styles for dropdown and entities shortcut in header
@frascuchon frascuchon moved this from In progress to Review in Release Feb 15, 2022
@frascuchon frascuchon moved this from Review to Ready to DEV QA in Release Feb 15, 2022
@frascuchon
Copy link
Member

The "Cancel" button action, but we can tackle in v2.

@Amelie-V
Copy link
Member Author

QA OK

frascuchon pushed a commit that referenced this issue Feb 17, 2022
styles fixes and lighter entities color

Closes #1063
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Feb 17, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Feb 17, 2022
frascuchon pushed a commit that referenced this issue Feb 17, 2022
This PR adds new UI, improves content selection in Token Classifier, improves styles and shortcut for annotation

* prediction tooltip position

* show prediction style when editing record

* dropdown styles

* short cut for selector

* remove origin property

* allow scroll dropdown

* prevent undefined element

* styles last selected whitespace

* dropdown scroll

* fix lint

(cherry picked from commit 9f0da39)
frascuchon pushed a commit that referenced this issue Feb 17, 2022
leiyre pushed a commit that referenced this issue Feb 17, 2022
fix #1063
This PR fixes visualization when record predictions are empty
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release Feb 17, 2022
frascuchon pushed a commit that referenced this issue Feb 17, 2022
This PR fixes visualization when record predictions are empty
frascuchon pushed a commit that referenced this issue Feb 17, 2022
This PR fixes visualization when record predictions are empty

(cherry picked from commit b7ed6e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release
Approved Release QA
4 participants