Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search bar] Adjust search bar size based on device #1121

Closed
frascuchon opened this issue Feb 10, 2022 · 2 comments · Fixed by #1124
Closed

[Search bar] Adjust search bar size based on device #1121

frascuchon opened this issue Feb 10, 2022 · 2 comments · Fixed by #1124
Assignees
@leiyre @Amelie-V
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@frascuchon
Copy link
Member

Large screen:

Screenshot 2022-02-10 at 10 07 16

Laptop:
Captura de pantalla 2022-02-10 a las 10 04 17
@frascuchon frascuchon added type: bug Indicates an unexpected problem or unintended behavior app labels Feb 10, 2022
@frascuchon frascuchon added this to Backlog in Release via automation Feb 10, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Feb 10, 2022
@Amelie-V
Copy link
Member

Captura de pantalla 2022-02-10 a las 10 05 52

@Amelie-V
Copy link
Member

  • Search area size should be adapted to size screen.

The fifth modal should always fit on left size, we need to text

  • On XL Extend it a bit (around 80px?)
  • On Laptop Reduce it (around 80px?)

leiyre added a commit that referenced this issue Feb 10, 2022
@leiyre
fix(#1121): Adjust search bar width
342eb47 
fix #1121

This PR limits the width of the search bar for all devices to the available space allowing full display of the dropdown filters
@leiyre leiyre mentioned this issue Feb 10, 2022
Merged
frascuchon pushed a commit that referenced this issue Feb 10, 2022
@leiyre
fix(#1121): Adjust search bar width (#1124)
70ce3e1 
This PR limits the width of the search bar for all devices to the available space allowing full display of the dropdown filters

Closes #1121
@frascuchon frascuchon moved this from Planified to Review in Release Feb 10, 2022
@frascuchon frascuchon moved this from Review to Ready to DEV QA in Release Feb 10, 2022
@Amelie-V Amelie-V moved this from Ready to DEV QA to Approved DEV QA in Release Feb 10, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Feb 10, 2022
frascuchon pushed a commit that referenced this issue Feb 10, 2022
@leiyre @frascuchon
chore(#982): Adjust search bar width (#1124)
0e027b2 
This PR limits the width of the search bar for all devices to the available space allowing full display of the dropdown filters

Closes #1121

(cherry picked from commit 70ce3e1)
dvsrepo added a commit that referenced this issue Feb 10, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8342b51 
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
@Amelie-V Amelie-V moved this from Ready to Release QA to Approved Release QA in Release Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1121): Adjust search bar width argilla-io/argilla
3 participants
@frascuchon @leiyre @Amelie-V