refactor(#945): using new search service #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
==========================================
+ Coverage 94.98% 95.00% +0.01%
==========================================
Files 119 121 +2
Lines 4491 4562 +71
==========================================
+ Hits 4266 4334 +68
- Misses 225 228 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dcfidalgo
approved these changes
Feb 10, 2022
frascuchon
pushed a commit
that referenced
this pull request
Feb 10, 2022
dvsrepo
added a commit
that referenced
this pull request
Feb 10, 2022
* 'master' of https://github.com/recognai/rubrix: (26 commits) feat(#1061): unify records results title (#1111) refactor(#945): using new search service (#1117) fix(#1121): Adjust search bar width (#1124) fix(#945): validate label for single label text classification dataset (#1123) docs: fix skweak images (#1120) fix(#831): Remove sort field when only one is applied (#1116) refactor(#945): add current search aggregations as metrics (#1115) chore(#982): extends search area (#1112) chore(#1054): long records margin adjustment #1114 feat(#1063): Token Classifier fine tuning content selection (#1084) refactor(#1102): remove "Update Summary" button rules summary (#1110) refactor(#945): revert index config for text2text (#1108) fix: convert pd.NaT to None for event_timestamp (#1105) fix(#1094): return empty list for no predicted_as (#1107) docs(#1089): remove pip install elasticsearch from docs (#1104) fix(#1054): reduce collapsable area. Optimize for annotation (#1106) fix(#945): include default aggregations for text2text (#1097) refactor(#1044): include last updated field for sort (#1093) fix(#1094): remove computed record fields returned in API results (#1095) feat(#1051): keep predictions labels when annotating (#1077) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the implementation for
SearchRecordsServiceclass and changes all task services search method, that will use the new implemented service.This will help in a future to normalize api task search and simplify development.