fix(DeviceService): Fixed isPresentingHMD state thrashing

the-reality-engineer · the-reality-engineer · commit 3c5763f9ad6c · 2017-04-27T16:40:54.000-04:00
diff --git a/src/device.ts b/src/device.ts
@@ -668,7 +668,7 @@ export class DeviceService {
     }
 
     get isPresentingHMD() : boolean {
-        return this.frameState.isPresentingHMD;
+        return this.frameState.isPresentingHMD || !!this._vrDisplay && this._vrDisplay.isPresenting;
     }
 
     requestPresentHMD() : Promise<void> {
@@ -942,6 +942,7 @@ export class DeviceServiceProvider {
         stableState.geolocationDesired = this.contextServiceProvider.geolocationDesired;
         stableState.geolocationOptions = this.contextServiceProvider.desiredGeolocationOptions;
         stableState.suggestedUserHeight = this.suggestedUserHeight;
+        stableState.isPresentingHMD = this.deviceService.isPresentingHMD;
 
         this.onUpdateStableState(this.deviceService._stableState);
 

Original file line number	Diff line number	Diff line change
`@@ -668,7 +668,7 @@ export class DeviceService {`
`668`	`668`	`}`
`669`	`669`
`670`	`670`	`get isPresentingHMD() : boolean {`
`671`		`- return this.frameState.isPresentingHMD;`
	`671`	`+ return this.frameState.isPresentingHMD \|\| !!this._vrDisplay && this._vrDisplay.isPresenting;`
`672`	`672`	`}`
`673`	`673`
`674`	`674`	`requestPresentHMD() : Promise<void> {`
`@@ -942,6 +942,7 @@ export class DeviceServiceProvider {`
`942`	`942`	`stableState.geolocationDesired = this.contextServiceProvider.geolocationDesired;`
`943`	`943`	`stableState.geolocationOptions = this.contextServiceProvider.desiredGeolocationOptions;`
`944`	`944`	`stableState.suggestedUserHeight = this.suggestedUserHeight;`
	`945`	`+ stableState.isPresentingHMD = this.deviceService.isPresentingHMD;`
`945`	`946`
`946`	`947`	`this.onUpdateStableState(this.deviceService._stableState);`
`947`	`948`