Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 0.4.1 to 1.0.0 #10509

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 11, 2023

Bumps github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 0.4.1 to 1.0.0.

Release notes

Sourced from github.com/Azure/azure-sdk-for-go/sdk/storage/azblob's releases.

sdk/resourcemanager/loadtestservice/armloadtestservice/v1.0.0

1.0.0 (2022-10-13)

Features Added

  • New function NewQuotasClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QuotasClient, error)
  • New function *QuotasClient.CheckAvailability(context.Context, string, string, QuotaBucketRequest, *QuotasClientCheckAvailabilityOptions) (QuotasClientCheckAvailabilityResponse, error)
  • New function *QuotasClient.NewListPager(string, *QuotasClientListOptions) *runtime.Pager[QuotasClientListResponse]
  • New function *LoadTestsClient.NewListOutboundNetworkDependenciesEndpointsPager(string, string, *LoadTestsClientListOutboundNetworkDependenciesEndpointsOptions) *runtime.Pager[LoadTestsClientListOutboundNetworkDependenciesEndpointsResponse]
  • New function *QuotasClient.Get(context.Context, string, string, *QuotasClientGetOptions) (QuotasClientGetResponse, error)
  • New struct CheckQuotaAvailabilityResponse
  • New struct CheckQuotaAvailabilityResponseProperties
  • New struct EndpointDependency
  • New struct EndpointDetail
  • New struct LoadTestsClientListOutboundNetworkDependenciesEndpointsOptions
  • New struct LoadTestsClientListOutboundNetworkDependenciesEndpointsResponse
  • New struct OutboundEnvironmentEndpoint
  • New struct OutboundEnvironmentEndpointCollection
  • New struct QuotaBucketRequest
  • New struct QuotaBucketRequestProperties
  • New struct QuotaBucketRequestPropertiesDimensions
  • New struct QuotaResource
  • New struct QuotaResourceList
  • New struct QuotaResourceProperties
  • New struct QuotasClient
  • New struct QuotasClientCheckAvailabilityOptions
  • New struct QuotasClientCheckAvailabilityResponse
  • New struct QuotasClientGetOptions
  • New struct QuotasClientGetResponse
  • New struct QuotasClientListOptions
  • New struct QuotasClientListResponse

sdk/resourcemanager/loadtesting/armloadtesting/v1.0.0

1.0.0 (2022-11-18)

The package of github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/loadtesting/armloadtesting is using our next generation design principles.

To learn more, please refer to our documentation Quick Start.

sdk/resourcemanager/billingbenefits/armbillingbenefits/v1.0.0

1.0.0 (2022-12-23)

The package of github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/billingbenefits/armbillingbenefits is using our next generation design principles.

To learn more, please refer to our documentation Quick Start.

sdk/resourcemanager/mobilenetwork/armmobilenetwork/v1.0.0

1.0.0 (2022-12-23)

Breaking Changes

  • Type of LocalDiagnosticsAccessConfiguration.HTTPSServerCertificate has been changed from *KeyVaultCertificate to *HTTPSServerCertificate

... (truncated)

Commits
  • 1988e0c Aded DeleteDisk method
  • 72aed89 Added CheckHostedServiceNameAvailability method, fixed minor bugs
  • 84da83b Update README.md
  • 2edf9b0 Added parameters validation
  • a870bf1 Removed "ResourceNotFound" check from vmClient
  • 116b917 Added RoleInstance entity to vmClient
  • 4f1c2ed Formatted entities in clients
  • 0adc3f4 Removed fingerprint printing from vmClient
  • a1a6933 Fixed SendAzureDeleteRequest method
  • 3f2caf9 Added new VM operations
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/Azure/azure-sdk-for-go/sdk/storage/azblob](https://github.com/Azure/azure-sdk-for-go) from 0.4.1 to 1.0.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/azcore/v0.4.1...v1.0)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Feb 11, 2023
@github-actions github-actions bot enabled auto-merge (squash) February 11, 2023 08:59
auto-merge was automatically disabled February 12, 2023 16:36

Merge queue setting changed

@alexec
Copy link
Contributor

alexec commented Feb 12, 2023

@dependabot ignore this major version

@dependabot dependabot bot closed this Feb 12, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 12, 2023

OK, I won't notify you about version 1.x.x again, unless you re-open this PR. 😢

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob-1.0.0 branch February 12, 2023 17:01
@roelarents
Copy link
Contributor

should this PR be re-openend? last update (#12459) was manually. maybe it can be automatically again? (i don't know the reason why it was disabled/ignored)

@agilgur5
Copy link
Member

agilgur5 commented Jan 17, 2024

should this PR be re-openend?

This was properly updated in #11251 as it had breaking changes that needed updating code

last update (#12459) was manually. maybe it can be automatically again? (i don't know the reason why it was disabled/ignored)

Afaict, some maintainers in the past just closed or ignored these PRs when they failed CI, which I don't think is a good approach, especially when there is no reason documented (as you point out and as I have in the past too).
I did request that no one do this and that we leave these open until there is a superseding PR (in a few Contributor Meetings and on other PRs like these), so it hasn't happened in more recent times.

We should remove all the manual ignores from messages like these and only keep the explicit ignores in the dependabot.yml.
I don't have write permissions yet to tag dependabot and have it listen to me though.
It is pretty confusing that dependabot allows two sources of truth: random comments like these and also the dependabot.yml -- it should really be one, the explicit file, if it exists

@agilgur5
Copy link
Member

agilgur5 commented Feb 5, 2024

2 recent changes:

@agilgur5
Copy link
Member

agilgur5 commented Feb 5, 2024

@dependabot show * ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 5, 2024

No ignore conditions found for the dependency *

@agilgur5
Copy link
Member

agilgur5 commented Feb 5, 2024

@dependabot show github.com/Azure/azure-sdk-for-go/sdk/storage/azblob ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 5, 2024

Ignore Conditions
Dependency Ignore Condition
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob [>= 1.a, < 2]

@agilgur5
Copy link
Member

agilgur5 commented Feb 5, 2024

@dependabot unignore github.com/Azure/azure-sdk-for-go/sdk/storage/azblob

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 5, 2024

Non Grouped Update Pull Requests do not support unignore commands.

@agilgur5
Copy link
Member

agilgur5 commented Feb 5, 2024

Turns out this is somehow impossible to fix in current dependabot 😐 : dependabot/dependabot-core#6489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants