Fix: Skip explicit undefined values in stringifyCSSProperties #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkarlov
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fix: Skip explicit undefined values in stringifyCSSProperties
This PR fixes #11 — handling cases where CSSProperties may contain value is explicitly set to
undefined.✅ Changes
Added a type guard to ensure only string or number values are processed.
Updated stringifyCSSProperties to skip properties with invalid values (undefined, null, objects, etc.).
Removed a test case that expected an error to be thrown for invalid input — since invalid values are now gracefully ignored.
Added new tests for undefined and null cases.
Added a publishing checklist doc (
docs/publishing.md) with manual publishing instructions.✅ Expected behavior
Previously, passing undefined values caused the lib to throw.
Now such values are silently skipped, ensuring safe and predictable behavior.