-
-
Notifications
You must be signed in to change notification settings - Fork 8
Fetch Armbian kernel package versions from beta repository #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Walkthrough
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
04e6631 to
0ead312
Compare
d40e5bd to
98497e3
Compare
98497e3 to
44e37d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (5)
.github/workflows/repository-status.yaml (4)
22-23: Ref to feature branch may break after merge.
ref: repostatusties the workflow to a short-lived branch. After merge/deletion, templates won’t be available. Prefer default (main) or a stable ref.- ref: repostatus +# ref: main # use stable default; or drop to use the workflow’s ref
51-53: Escape sed replacement to handle any special chars.If versions ever contain
&or/, the sed substitution will misbehave. Escape the replacement value.- sed "s/{{VERSION}}/$CURRENT/g" armbian.github.io/templates/armbian-badge-current.svg > current.svg - sed "s/{{VERSION}}/$EDGE/g" armbian.github.io/templates/armbian-badge-edge.svg > edge.svg + esc() { printf '%s' "$1" | sed -e 's/[\/&]/\\&/g'; } + sed "s/{{VERSION}}/$(esc "$CURRENT")/g" armbian.github.io/templates/armbian-badge-current.svg > current.svg + sed "s/{{VERSION}}/$(esc "$EDGE")/g" armbian.github.io/templates/armbian-badge-edge.svg > edge.svg
12-15: Job id/name mismatch.Job id
jirais confusing here. Consider renaming for clarity.-jobs: - jira: +jobs: + repository: runs-on: ubuntu-24.04 - name: "Get from Armbian Repository" + name: "Get from Armbian Repository"
69-75: YAML lint: trim trailing spaces and add newline at EOF.Fix the trailing space on Line 70 and ensure the file ends with a newline.
- git push - + git push + - name: "Run Bigin update action" uses: peter-evans/repository-dispatch@v3 with: token: ${{ secrets.GITHUB_TOKEN }} event-type: "MOTD update" +```.github/workflows/generate-motd.yaml (1)
48-52: Add newline at EOF.Satisfy yamllint by ending the file with a newline.
- name: "Run Bigin update action" uses: peter-evans/repository-dispatch@v3 with: token: ${{ secrets.GITHUB_TOKEN }} - event-type: "Bigin update" + event-type: "Bigin update" +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (4)
templates/armbian-badge-current.svgis excluded by!**/*.svgtemplates/armbian-badge-edge.svgis excluded by!**/*.svgtemplates/current-template.svgis excluded by!**/*.svgtemplates/edge-template.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
.github/workflows/generate-jira-excerpt.yml(1 hunks).github/workflows/generate-motd.yaml(2 hunks).github/workflows/repository-status.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/repository-status.yaml
[error] 70-70: trailing spaces
(trailing-spaces)
[error] 75-75: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/generate-motd.yaml
[error] 52-52: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.github/workflows/repository-status.yaml (1)
3-5: Trigger scope check.Including
push:will run this workflow on every push, not just on repository_dispatch. Confirm this is intended to avoid unexpected pushes to the data branch..github/workflows/generate-jira-excerpt.yml (1)
46-51: Dispatch event rename looks good.Event type updated to “Repository status” and step name clarified. Matches the new workflow trigger.
.github/workflows/generate-motd.yaml (1)
13-13: LGTM on job rename.Clearer job name.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
@coderabbitai generate README.md entry for this action |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 13919 🏁 Script executed: Length of output: 1604 @igorpecovnik I'll generate a README.md entry for the new repository status action. Based on my analysis of the workflow and existing documentation structure, here's the entry to add to your README.md: - **Fetch Armbian Kernel Package Versions**
<a href=https://github.com/armbian/armbian.github.io/actions/workflows/repository-status.yaml><img alt="GitHub Workflow Status" src="https://img.shields.io/github/actions/workflow/status/armbian/armbian.github.io/repository-status.yaml?logo=githubactions&label=Status&style=for-the-badge&branch=main&logoColor=white"></a>
Fetches latest CURRENT and EDGE kernel package versions from Armbian's beta repository and generates SVG badges and JSON output.
[Generated Data →](https://github.armbian.com/kernel-versions.json)This entry should be placed in the "Metadata & Content Generation" section of your README.md, fitting naturally with the other similar automation workflows. The workflow:
The generated files can be used for:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README.md (2)
69-69: Quote the href to satisfy markdownlint MD034 (bare URL).Quoting the attribute URL avoids the bare-URL warning.
- <a href=https://github.com/armbian/armbian.github.io/actions/workflows/repository-status.yaml><img alt="GitHub Workflow Status" src="https://img.shields.io/github/actions/workflow/status/armbian/armbian.github.io/repository-status.yaml?logo=githubactions&label=Status&style=for-the-badge&branch=main&logoColor=white"></a> + <a href="https://github.com/armbian/armbian.github.io/actions/workflows/repository-status.yaml"><img alt="GitHub Workflow Status" src="https://img.shields.io/github/actions/workflow/status/armbian/armbian.github.io/repository-status.yaml?logo=githubactions&label=Status&style=for-the-badge&branch=main&logoColor=white"></a>
68-71: Add a direct link to the generated data for quick access.A link to kernel-versions.json helps consumers and badge services.
- Fetches the latest CURRENT and EDGE kernel package versions from Armbian's beta repository and generates SVG badges and a JSON file. + Fetches the latest CURRENT and EDGE kernel package versions from Armbian's beta repository and generates SVG badges and a JSON file. + Data: [kernel-versions.json](https://github.armbian.com/kernel-versions.json)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/repository-status.yaml(1 hunks)README.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/repository-status.yaml
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~68-~68: There might be a mistake here.
Context: ... Fetch Armbian Kernel Package Versions <a href=https://github.com/armbian/armbi...
(QB_NEW_EN)
[grammar] ~69-~69: There might be a mistake here.
Context: ...ctions/workflows/repository-status.yaml> Fetches latest CURRENT and EDGE kernel p...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
README.md
69-69: Bare URL used
(MD034, no-bare-urls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
70-71: Add a direct link to the generated JSON for convenience.Quick-access link helps consumers and matches other entries that link outputs.
Apply:
Fetches the latest CURRENT and EDGE kernel package versions from Armbian's beta repository and generates SVG badges and a JSON file. + + [Data →](https://github.armbian.com/kernel-versions.json)
69-69: Quote the href attribute (minor HTML/markdownlint nit).Quoting improves HTML validity and may quiet MD034 in some setups.
- <a href=https://github.com/armbian/armbian.github.io/actions/workflows/repository-status.yaml><img alt="GitHub Workflow Status" src="https://img.shields.io/github/actions/workflow/status/armbian/armbian.github.io/repository-status.yaml?logo=githubactions&label=Status&style=for-the-badge&branch=main&logoColor=white"></a> + <a href="https://github.com/armbian/armbian.github.io/actions/workflows/repository-status.yaml"><img alt="GitHub Workflow Status" src="https://img.shields.io/github/actions/workflow/status/armbian/armbian.github.io/repository-status.yaml?logo=githubactions&label=Status&style=for-the-badge&branch=main&logoColor=white"></a>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~68-~68: There might be a mistake here.
Context: ... Fetch Armbian Kernel Package Versions <a href=https://github.com/armbian/armbi...
(QB_NEW_EN)
[grammar] ~69-~69: There might be a mistake here.
Context: ...ctions/workflows/repository-status.yaml> Fetches the latest CURRENT and EDGE kern...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
README.md
69-69: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Get from Armbian Repository
🔇 Additional comments (2)
README.md (2)
68-71: New entry reads well; grammar fix applied.The description is clear and consistent with the workflow intent.
68-69: No changes required; workflow filename matches badge URL
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
91bc643 to
46883c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
README.md (1)
68-71: LGTM; resolves prior grammar nit.The sentence now includes “the” and “a JSON file,” addressing the earlier suggestion.
🧹 Nitpick comments (2)
README.md (2)
69-69: Quote the href URL to satisfy MD034 and HTML style.Use quotes around the href attribute.
- <a href=https://github.com/armbian/armbian.github.io/actions/workflows/repository-status.yaml><img alt="GitHub Workflow Status" src="https://img.shields.io/github/actions/workflow/status/armbian/armbian.github.io/repository-status.yaml?logo=githubactions&label=Status&style=for-the-badge&branch=main&logoColor=white"></a> + <a href="https://github.com/armbian/armbian.github.io/actions/workflows/repository-status.yaml"><img alt="GitHub Workflow Status" src="https://img.shields.io/github/actions/workflow/status/armbian/armbian.github.io/repository-status.yaml?logo=githubactions&label=Status&style=for-the-badge&branch=main&logoColor=white"></a>
70-71: Add a direct link to the published JSON.Convenience link, mirrors “Docs →/Redirector →” style used elsewhere.
Fetches the latest CURRENT and EDGE kernel package versions from Armbian's beta repository and generates SVG badges and a JSON file. + + [Data →](https://github.armbian.com/kernel-versions.json)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/repository-status.yaml(1 hunks)README.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/repository-status.yaml
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~68-~68: There might be a mistake here.
Context: ... Fetch Armbian Kernel Package Versions <a href=https://github.com/armbian/armbi...
(QB_NEW_EN)
[grammar] ~69-~69: There might be a mistake here.
Context: ...ctions/workflows/repository-status.yaml> Fetches the latest CURRENT and EDGE kern...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
README.md
69-69: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Get from Armbian Repository
🔇 Additional comments (1)
README.md (1)
70-70: Confirm scope (x86-only?).If this workflow queries linux-image-current-x86/edge-x86, consider noting “x86” to avoid ambiguity; otherwise ignore.
Summary
This PR adds a script to reliably fetch Armbian kernel package versions (
CURRENTandEDGE) from the official beta repository. The script:/usr/share/keyrings/armbian.gpg/etc/apt/sources.list.d/armbian.listapt-cache madisonkernel-versions.jsonImprovements over previous version
curlwithgpg --dearmor(avoids temporary files)UBUNTU_CODENAME) and Debian (VERSION_CODENAME)apt-cache madisoninstead of brittlegrep/headparsingset -euo pipefail)templates/current-template.svg,templates/edge-template.svg)Example output
{ "CURRENT": "6.12.45", "EDGE": "6.16.5" }Examples of usage:
HTML code on existing places has to be replaced with this one:
SVG
Needs
?randomafter image to force refresh on browser.Shields.io
Refreshing is covered by shields.io service parameter.