Skip to content

Conversation

@Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Jun 5, 2022

@Tabaie
Copy link
Contributor Author

Tabaie commented Jun 5, 2022

On a (slightly) different note,

# NOTE: if init_ctr=1 fails to find Z, try setting it to F.gen()

I find this rather vague as it is not specified how many trials constitute a failure.

@armfazh armfazh merged commit 3348f2e into armfazh:master Jun 7, 2022
@armfazh
Copy link
Owner

armfazh commented Jun 7, 2022

I find this rather vague as it is not specified how many trials constitute a failure.

These parameters are generated offline per-field & per-curve.
So implementations shouldn't calculate these values online, (this library does calculate them, but only for compatibility reasons as this is the reference implementation).

@Tabaie
Copy link
Contributor Author

Tabaie commented Jun 8, 2022

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants