Add shortcut buttons for controlling model view #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add buttons for aligning and rotating model, as well as selecting all atoms. The user can specify the angle to be rotated with spin button. The rotation button images still need some improvement but hopefully are intelligible enough. Also changed the grouping of buttons slightly to be more "intuitive" (?). The new alignment buttons render the Model:Viewing buttons redundant, but the latter can be kept for the time being (although the menu buttons are easier to use). Also added shortcut key combination for "unhiding" all atoms, as well as notice of number of hidden atoms in model viewer. Also fixed several spelling mistakes in comments.
|
Oops, it seems that I forgot that pull request.
There is a little graphic bug where the "Selected X" text appear over the frame number, whenever a selection is made on a multiple frame model. then select a few / all atoms. Everything else seems OK. |
|
Oh, thanks. I hadn't checked that and will try to come up with a fix soon.
…________________________________
差出人: Okadome Valencia ***@***.***>
送信日時: 2021年7月1日 19:57
宛先: arohl/gdis ***@***.***>
CC: ｸﾚｲｸﾞ･ﾌｨｯｼｬｰ ***@***.***>; Author ***@***.***>
件名: Re: [arohl/gdis] Add shortcut buttons for controlling model view (#40)
Oops, it seems that I forgot that pull request.
number of hidden atoms in model viewer
There is a little graphic bug where the "Selected X" text appear over the frame number, whenever a selection is made on a multiple frame model.
for example, from the src subdirectory:
../bin/gdis ../models/vasprun.xml
then select a few / all atoms.
Everything else seems OK.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#40 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP5N32G4KIVFXUYYLS7ISM3TVRC2VANCNFSM47DNNGGA>.
|
|
There is also a problem when the viewer is split into more than one canvas. This appears to be a more general problem, though, with other modes displayed incorrectly in multiple canvases, so might take a bit longer to fix.
…________________________________
差出人: Okadome Valencia ***@***.***>
送信日時: 2021年7月1日 19:57
宛先: arohl/gdis ***@***.***>
CC: ｸﾚｲｸﾞ･ﾌｨｯｼｬｰ ***@***.***>; Author ***@***.***>
件名: Re: [arohl/gdis] Add shortcut buttons for controlling model view (#40)
Oops, it seems that I forgot that pull request.
number of hidden atoms in model viewer
There is a little graphic bug where the "Selected X" text appear over the frame number, whenever a selection is made on a multiple frame model.
for example, from the src subdirectory:
../bin/gdis ../models/vasprun.xml
then select a few / all atoms.
Everything else seems OK.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#40 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP5N32G4KIVFXUYYLS7ISM3TVRC2VANCNFSM47DNNGGA>.
|
Info text for number of selected and hidden atoms moved to lower left-hand corner of canvas.
|
Info text for "selected" and "hidden" atoms moved to lower left-hand corner of canvas |
|
Hello and enable energy toggle in display, here is what I get for the problematic models (see the lower-right corner): This also happen for USPEX display: you can also try To see how the other models behave. Best, |
Adds option to show shell charges from render dialogue, in addition to core charges and total atom charges.
Toggles for total atom charges, core charges and shell charges brought together in render dialogue.
Also rearrange info display positions so that energy is right-hand top corner, selected and hidden is lower left-hand corner and animation slices are centred above model.
Toggles for displaying total atom charges, core charges and shell charges grouped together.
Adds display of shell charges as well as total atom charges and core charges. Energy values moved to upper right-hand corner and movie slice numbers moved to centre above model.
|
Sorry about that. The energy wasn't supposed to go there.
I've rearranged the other info slightly so that there shouldn't be any overlap now.
…________________________________
差出人: Okadome Valencia ***@***.***>
送信日時: 2021年7月5日 18:32
宛先: arohl/gdis ***@***.***>
CC: ｸﾚｲｸﾞ･ﾌｨｯｼｬｰ ***@***.***>; Author ***@***.***>
件名: Re: [arohl/gdis] Add shortcut buttons for controlling model view (#40)
Hello
I see that the "selected" text was moved to the lower left corner, and the energy was combined with the "normal" mode text.
Unfortunately this leads to a graphic bug and now the energy value and "normal" text can sometimes overlap.
in src directory, try
../bin/gdis ../models/graphite.scf.qeout ../models/octane.got ../models/1_C2H4_HOOH_Tifer.arc ../models/aloh4-.car ../models/carbonate.car ../models/full.car ../models/gibb.car ../models/la_rdefe_clus.car ../models/water.car
and enable energy toggle in display, here is what I get for the problematic models (see the lower-right corner):
[pr_40]<https://user-images.githubusercontent.com/36496189/124449959-ed518700-ddbe-11eb-87c8-62985d6e94dd.png>
This also happen for USPEX display:
[pr_40_2]<https://user-images.githubusercontent.com/36496189/124450089-0b1eec00-ddbf-11eb-8680-41f83ee70d14.png>
you can also try
../bin/gdis ../models/*
To see how the other models behave.
Best,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#40 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP5N32H6YUNXP4BK7ER4KALTWF34HANCNFSM47DNNGGA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add buttons for aligning and rotating model, as well as selecting all atoms.
The user can specify the angle to be rotated with the spin button. The rotation button images still need some improvement but hopefully are intelligible enough at present.
Also changed the grouping of buttons slightly to be more "intuitive" (?).
These new alignment buttons render the Model:Viewing buttons redundant, but the latter can be kept for the time being (although the menu buttons are quicker to use).
Also added shortcut key combination for "unhiding" all atoms, as well as notice of number of hidden atoms in model viewer.
Also fixed several spelling mistakes in comments.