Fixes pyproject.toml failures, and constants.py issues #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzeezIsh
force-pushed
the
pyproject-failures
branch
from
0dcbf9c to
a67cae1
Compare
AzeezIsh
force-pushed
the
pyproject-failures
branch
from
a67cae1 to
f4543c0
Compare
syurkevi
approved these changes
Apr 18, 2024
edwinsolisf
pushed a commit
to edwinsolisf/arrayfire-py
that referenced
this pull request
Sep 24, 2025
* added constant tests * Fixed automatic checks - styling, import order, lint, static type checking * Corrected redundant checks within tests * Fixed import formatting and automatic checks * Added back in complex tests, made fix to get_scalar function in manage_array --------- Co-authored-by: Chaluvadi <saketh.chaluvadi@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed double precision Float64 issues in constants.py, with line pi = wrapper.constant(math.pi, (1,), af.float64)
Dependency Simplification: The dependencies are modified to consistently use "arrayfire-binary-python-wrapper == 0.7.0". Previously, there was a more specific version constraint ("arrayfire-binary-python-wrapper == 0.7.0+af3.9.0"), which has been simplified.
Removal of Redundant Entries: The dynamic array under the [project] section initially included "version", but this is now managed under [tool.setuptools.dynamic] where the version is set dynamically based on the attribute arrayfire.version.