-
Notifications
You must be signed in to change notification settings - Fork 58
Indexing #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexing #27
Conversation
|
This shall be merged after upstream PR has been merged and pulled in. |
|
@9prady9 : can you just test the |
|
@jramapuram I actually tested the changes in upstream PR with this PR changes already. row/col, index, index_gen - all these functions are working. I just haven't pushed the changes to this branch yet. I am waiting for upstream PR to merge so that i can update sub-module commit tag in rust wrapper. |
|
👍 |
|
@9prady9 : Can this be merged now since the upstream changes are in? Are there any required modifications to the indexing here so that it conforms to your changes in arrayfire mainline? I have pushed in the generic type for the af_host function as well. One thing that remains here is the updating of the submodule. If you could test this and update that I think we will be good to go. |
|
@jramapuram Just one last commit from my side. I have it on my local branch on the office machine. Will push it on Monday for sure. I will also update the tag then to |
|
Great, thanks! |
|
👍 |
Fixes #28
Fixes #26