Feature/add rows cols #33
Conversation
src/index.rs
Outdated
There was a problem hiding this comment.
@jramapuram We do not need to retrieve dimensions, just doing &[Seq::new(first, last, 1), Seq::default()] would be enough for this. This way one less ffi call in terms of input.dims().
Seq::default is the equivalent of af_span in C API of ArrayFire that spans all elements along that dimension.
There was a problem hiding this comment.
Will refactor to span.
What about assertion of ranges? I.e. making sure first & last are contained within the max_rows?
There was a problem hiding this comment.
Should be fine i think, index call will return appropriate error code if something is wrong. I don't think we should duplicate error checks in rust wrapper unless absolutely required.
|
@jramapuram Can also please add slices wrapper, it would be exactly same except that the Seq using the parameters would be along third dimension. |
|
Cool will refactor to seq default & add span |
…l, set_rows, set_cols
|
@9prady9 : Refactored and added setters. Please review. |
|
👍 |
Upstream has:
rows()cols()Adding these to the wrapper.