Surface fixes and Increment version to 0.9.2 #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shehzan10
requested changes
Dec 19, 2016
examples/cpu/surface.cpp
Outdated
| static const float XMIN = -32.0f; | ||
| static const float XMAX = 32.f; | ||
| static const float YMIN = -32.0f; | ||
| static const float YMAX = 32.f; |
Member
There was a problem hiding this comment.
static const float XMIN = -32.0f;
static const float XMAX = 32.0f;
static const float YMIN = -32.0f;
static const float YMAX = 32.0f;
Consistency of space and 0 after decimal point. I added 0s cuz 2 of them had it.
|
|
||
| if (r < (rows-2)) { | ||
| // repeat last vertex for degenerate triangle | ||
| indices.push_back(((r + 1) * rows) + (cols - 1)); |
Member
There was a problem hiding this comment.
push_back it's great. Or at least without reserve it isnt. Can we reserve/resize before push_back?
@umar456 thoughts?
Member
Author
There was a problem hiding this comment.
Yes, the size is known ahead. we can do that.
Member
Author
There was a problem hiding this comment.
I didn't do it because this function won't be called from render loop.
shehzan10
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.