Skip to content

Conversation

@zopieux
Copy link
Contributor

@zopieux zopieux commented Dec 4, 2017

See #149.

@coveralls
Copy link

coveralls commented Dec 4, 2017

Coverage Status

Coverage increased (+0.2%) to 92.149% when pulling 6f89789 on Zopieux:develop into ac08b69 on arteria:develop.

@zopieux
Copy link
Contributor Author

zopieux commented Dec 4, 2017

😕 My face when the patch works locally but not in Travis. Stay tuned.

@zopieux
Copy link
Contributor Author

zopieux commented Dec 4, 2017

Actually it did not, I can't read. Django 2.0 changed the way it connects the signal we want to hide (uses an UID instead of just the receiver function id). Requires disconnecting both cases, or using version-specific code (I don't want the latest). This update should work and the test covers the hijacker case: we don't want to update the hijacker last login neither!

@coveralls
Copy link

coveralls commented Dec 4, 2017

Coverage Status

Coverage increased (+0.3%) to 92.308% when pulling 0160dbc on Zopieux:develop into ac08b69 on arteria:develop.

@walterrenner walterrenner mentioned this pull request Dec 5, 2017
@walterrenner walterrenner merged commit b46c938 into django-hijack:develop Dec 5, 2017
@zopieux zopieux deleted the develop branch December 5, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants