Skip to content

Conversation

@rallysson
Copy link
Contributor

@rallysson rallysson commented Oct 26, 2018

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Without the postinstall script, Travis CI would pick up parse from date-fns v1 because the fake package date-fns-v2 dependencies are not installed.

What is the new behavior?
The dependencies of the date-fns-v2 folder are installed after the library dependencies.

@vercel
Copy link

vercel bot commented Oct 26, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov-io
Copy link

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     9.5%   9.5%           
=====================================
  Files          13     13           
  Lines         284    284           
  Branches       56     56           
=====================================
  Hits           27     27           
  Misses        205    205           
  Partials       52     52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b84006...96f8da7. Read the comment docs.

@arthurdenner
Copy link
Owner

Thanks, @rallysson! Great fix, I totally missed this detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants