Skip to content

Conversation

@arthurdenner
Copy link
Owner

@arthurdenner arthurdenner commented Oct 8, 2019

What kind of change does this PR introduce?
Feature, bug fix and docs update. Closes #44.

What is the current behavior?

  • Typings are maintained manually which is not great;
  • Our build is not so small, around ~63kb;
  • Our documentation is not up-to date and has some invalid examples.

What is the new behavior?

  • The library uses TypeScript and the typing are generated automatically;
  • The build size with tsdx is smaller;
  • Our documentation uses a recent version of Storybook and only has valid examples.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

⚠️ There are a few things left in order to merge this PR: ⚠️

  • There is only one CSS file after building the project and it's tagged as development;
  • We are using an old version of rollup-plugin-copy, would be nice if we could update it. (it's better to skip it for now since the latest version is not compatible with tsdx)

@arthurdenner arthurdenner added the enhancement New feature or request label Oct 8, 2019
@vercel
Copy link

vercel bot commented Oct 8, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@arthurdenner arthurdenner marked this pull request as ready for review October 8, 2019 20:58
@arthurdenner arthurdenner merged commit c0afb67 into develop Oct 9, 2019
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing props in SemmaticDatepickerProps interface definition

3 participants