Skip to content

Conversation

@fossamagna
Copy link
Contributor

@fossamagna fossamagna commented Oct 1, 2024

Description

Hi @arthurgeron , thanks for the work on this very useful plugin.

It appears that the feature proposed in #18 has not yet been implemented. Therefore, we have created this Pull Request. I would be grateful if you could review it.

Checklist

  • Tests: I have created multiple test case scenarios for my changes.
  • Passing Tests: All existing and new tests are passing.
  • Version Bump: I have increased the package version number in package.json following the Semantic Versioning (SEMVER) standard.
  • Focused Changes: My code changes are focused solely on the matter described above.

Additional Information

refs #18

- inline object/functions
- const functions
@fossamagna fossamagna requested a review from arthurgeron October 3, 2024 15:16
Copy link
Owner

@arthurgeron arthurgeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing missing is to increase the patch version of the package.
I've created a check + PR template to make this more clear in the future.

@fossamagna
Copy link
Contributor Author

@arthurgeron
Thank you for your review.
I increased the patch version of the package.

@arthurgeron arthurgeron merged commit 778b05d into arthurgeron:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants