-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal API redesign #150
Draft
artivis
wants to merge
7
commits into
devel
Choose a base branch
from
feature/functorize
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artivis
force-pushed
the
feature/functorize
branch
from
August 2, 2020 19:16
0dbd4ee
to
19177be
Compare
Codecov Report
@@ Coverage Diff @@
## devel #150 +/- ##
==========================================
+ Coverage 98.23% 98.25% +0.02%
==========================================
Files 37 71 +34
Lines 1130 1148 +18
==========================================
+ Hits 1110 1128 +18
Misses 20 20 |
17 tasks
This was referenced Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initiate a large cleanup of the internal API relying on traits to overload the different group/tangent functions for each derived. It cleans up the old API design debt where e.g.
Derived::inverse
hidesBase::inverse
. Going with this new design allows to more easily specialize functions where and if necessary. This will also (hopefully) open the door to,Comes on top of #147.