Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal API redesign #150

Draft
wants to merge 7 commits into
base: devel
Choose a base branch
from
Draft

Internal API redesign #150

wants to merge 7 commits into from

Conversation

artivis
Copy link
Owner

@artivis artivis commented Aug 2, 2020

This PR initiate a large cleanup of the internal API relying on traits to overload the different group/tangent functions for each derived. It cleans up the old API design debt where e.g. Derived::inverse hides Base::inverse. Going with this new design allows to more easily specialize functions where and if necessary. This will also (hopefully) open the door to,

  • implementing left-jacobian as proposed here
  • template expression (a la Eigen), altho that's not part of the foreseeable future

Comes on top of #147.

@artivis artivis added enhancement New feature or request API API change labels Aug 2, 2020
@artivis artivis self-assigned this Aug 2, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #150 into devel will increase coverage by 0.02%.
The diff coverage is 99.72%.

@@            Coverage Diff             @@
##            devel     #150      +/-   ##
==========================================
+ Coverage   98.23%   98.25%   +0.02%     
==========================================
  Files          37       71      +34     
  Lines        1130     1148      +18     
==========================================
+ Hits         1110     1128      +18     
  Misses         20       20              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants