-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python bindings #201
Add Python bindings #201
Conversation
See #179 for discussion backlogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on MacOSX.
Great work!
How can I execute the python examples? I´d like to see them running before approving
Codecov Report
@@ Coverage Diff @@
## devel #201 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 51 51
Lines 1506 1506
=======================================
Hits 1482 1482
Misses 24 24 |
First you need to install cd manif/examples
python3 se3_localization.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples checked and working. Approving with congrats
16e2e12
to
9beafaf
Compare
Post-approval update:
|
manifpy
Add Python bindings to manif.
Install,
Test,
Use,
Note
rjacinv/ljacinv
The functions
rjacinv/ljacinv
are not exposed at the moment. They are too complicated to wrap for little benefit.This will be fixed in the future after the internal API redesign (see e.g. #150).
Eigen/Geometry
-related APIThe C++ API related to
Eigen/Geometry
is not exposed. The rational is that this API only exists as a convenience to interface with existing classes inEigen
(Quaternion
/Transform
etc).The
Eigen
counterpart in Python isnumpy
which does not have such classes. We could wrap theEigen
objects to expose them to Python but that does not have much interest since they wont play nice withnumpy
unless we put some extra effort.At the moment this seems to be too much for the little outcome, especially since the different examples (
*_localization
/*_sam
) were ported without issues.For this reason this will be left to future work or contribution.
Todo list
Bindings:
rjacinv/ljacinv
Eigen/Geometry
-relatedMisc:
Cleanup version of #179
Comes after #200
Closes #187