Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous small fixes #200

Merged
merged 8 commits into from
Feb 13, 2021
Merged

Miscellaneous small fixes #200

merged 8 commits into from
Feb 13, 2021

Conversation

artivis
Copy link
Owner

@artivis artivis commented Feb 13, 2021

Miscellaneous small fixes:

@artivis artivis added bug Something isn't working API API change labels Feb 13, 2021
@artivis artivis self-assigned this Feb 13, 2021
@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #200 (74c57c6) into devel (48ba49d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel     #200   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          49       49           
  Lines        1475     1475           
=======================================
  Hits         1451     1451           
  Misses         24       24           

@artivis artivis mentioned this pull request Feb 13, 2021
17 tasks
Copy link
Collaborator

@joansola joansola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See some stupid remarks in the comments. Then I-ll approve.

examples/se3_sam.cpp Outdated Show resolved Hide resolved
examples/se3_sam.cpp Outdated Show resolved Hide resolved
examples/se3_sam_selfcalib.cpp Outdated Show resolved Hide resolved
examples/se3_sam_selfcalib.cpp Outdated Show resolved Hide resolved
@artivis
Copy link
Owner Author

artivis commented Feb 13, 2021

@joansola Can I get an approval to merge this PR as soon as CI is done?

Copy link
Collaborator

@joansola joansola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All agreed

@artivis artivis merged commit 6aaaae4 into devel Feb 13, 2021
@artivis artivis deleted the fix/misc branch February 13, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants