Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Check READMEs for point-people being in the Artsy org #24

Open
orta opened this issue Sep 28, 2017 · 2 comments
Open

RFC: Check READMEs for point-people being in the Artsy org #24

orta opened this issue Sep 28, 2017 · 2 comments

Comments

@orta
Copy link
Contributor

orta commented Sep 28, 2017

Proposal:

On every PR, which has a meta section like this:

Meta

This is a core Artsy Mobile OSS project, along with Energy, Eidolon, Emission and Emergence.

Fail the PR if the people who are assigned are still inside the Artsy org.

Reasoning

Code ownership changes naturally, but forgotten repos can get lost and no-one want to have orphaned. As people leave we should be re-applying who has ownership over the repo.

Failing is a strong call, but leaving the repo in a bad state isn't a great call either.

Exceptions:

There are probably a bunch of repos without the meta section. The meta section should ideally get added too them, but I think there's too many edge cases to make it worth forcing it on every repo. Open to changing that though.

@orta
Copy link
Contributor Author

orta commented Sep 28, 2017

The will look something like this: https://github.com/orta/artsy-check-readmes/blob/master/check.ts#L44-L82

@orta
Copy link
Contributor Author

orta commented May 7, 2018

This (and most scheduled tasks in general) need some kind of peril "create an issue and update it" API, where you pass an identifier and Peril will automatically keep that issue up to date (or create it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant