You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fail the PR if the people who are assigned are still inside the Artsy org.
Reasoning
Code ownership changes naturally, but forgotten repos can get lost and no-one want to have orphaned. As people leave we should be re-applying who has ownership over the repo.
Failing is a strong call, but leaving the repo in a bad state isn't a great call either.
Exceptions:
There are probably a bunch of repos without the meta section. The meta section should ideally get added too them, but I think there's too many edge cases to make it worth forcing it on every repo. Open to changing that though.
The text was updated successfully, but these errors were encountered:
This (and most scheduled tasks in general) need some kind of peril "create an issue and update it" API, where you pass an identifier and Peril will automatically keep that issue up to date (or create it).
Proposal:
On every PR, which has a meta section like this:
Fail the PR if the people who are assigned are still inside the Artsy org.
Reasoning
Code ownership changes naturally, but forgotten repos can get lost and no-one want to have orphaned. As people leave we should be re-applying who has ownership over the repo.
Failing is a strong call, but leaving the repo in a bad state isn't a great call either.
Exceptions:
There are probably a bunch of repos without the meta section. The meta section should ideally get added too them, but I think there's too many edge cases to make it worth forcing it on every repo. Open to changing that though.
The text was updated successfully, but these errors were encountered: