SQLCallStackResolver 2.0 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
arvindshmicrosoft
commented
Aug 7, 2020
arvindshmicrosoft
commented
- Logically rearrange UI and other misc changes
- Implement long-running ops as background threads
- Bug fixes to correctly lookup PDB source info in specific cases
- Improved implementation of "relookup source" functionality
- Additional validations to avoid common operator error
- Use registration-free COM activation for msdia140
- Public symbol download info for SQL builds is in the tool
- Update README and add screenshots
- Update and trim NuGet dependencies
- Switch to xUnit.net for tests
- Add GitHub Action to build automatically on every branch push
- Panels, so now resizing UI gets more space for the individual items - Added UI placeholder for functionality that will automatically download PDBs for given build
- Added a facade for the ability to download PDBs for a given SQL build. - Also added a basic status bar
- Important bug fix in the ObtainDLLDownload code path; we now explicitly look for DLL or EXE files - SQLBuildInfo abstractions improved
- Symbol download URLs for SQL 2012 SP2 - SQL 2019 - UI will only show builds for which URLs are present
- Move GUI to a folder of its own
- basic functionality of downloading PDBs for a selected build is now working, with progress reporting.
- Build info file was updated - Seeding a last-updated timestamp file
Actually implements the update logic
Earlier we would return a list of strings each containing a download URL. Now we return a list of Symbol classes each of which has the URL, file version and PDB name
- Move to CLRMd 2.0 beta - Move from PEFile to PEImage - Move to .NET Framework 4.7.2 - Enhance symbol download checks - Updated SQLBuildInfo.json - Cleanup NuGet refs
Incorporates PDB lookup perf improvement work and WinDbg backtick address support.
* UI is now arranged as a set of steps that the user can take * Option to redirect output to a text file * Skip download of PDB if already downloaded * Bug fix for non-aggregated XEL import
* No longer block UI on long-running ops * Better status reporting and new progress reporting * Ability to cancel long-running ops
Fixes a minor issue wherein the first frame of a callstack copied directly from the SSMS window would be ignored, as it is tab-separated instead of the expected space.
Adds the ProductLevel as part of the ToString() method and also adds a Flush / Close when writing to JSON output
* Rev dependency versions * Using FileStream to work around strange 0-byte file issue * Updated build info JSON
* Go back to released dependencies * Make the binding redirects consistent * Add details for a SQL 2012 hotfix
* Switch to using RVA for relookup source operation * .dll extension should not be mandatory * Consider function overloads when looking up syms by func name
* Builds are now sorted descending order for major, prod level and build numbers as well * Added build info for SQL 2017 CU15 GDR
* Correct the check to detect if PDB has source info * Add messages to guide user for PDB caching * Update to latest ClrMD * Rename toolTip field in GUI
* Add manifest files and reference those for COM activation * Bump version number to 2.0.0.0 * Update README * Centralize generation of PowerShell download scripts * Update ClrMd to latest beta * Minor UI tweak to increase size of main button
* Replace custom console project with xUnit library * Modify GitHub workflow to invoke xUnit console runner * Switch to embed reg-free COM manifest into Engine DLL rather than client app. This is necessary for xUnit tests to work. * Delete AnyCPU project config and replace with x64 exclusively * Add multiple test cases * Enable FxCop and StyleCop Analyzers
* Add search for known build symbols download UI * Add UI validation for single-line callstack * Bump ClrMd version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.