Fix auto-update logic #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The earlier logic was based on local file last modified timestamp, which was flawed for the case when the utility is extracted from GitHub - in that case, the sqlbuildinfo.json file last modified timestamp is always going to be more recent than the value contained in lastupdated.txt.
arvindshmicrosoft
force-pushed
the
fix-auto-update-bug
branch
from
17cce73 to
890c5ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier logic was based on local file last modified timestamp, which
was flawed for the case when the utility is extracted from GitHub - in
that case, the sqlbuildinfo.json file last modified timestamp is always
going to be more recent than the value contained in lastupdated.txt.