Skip to content

🐛 fix: corrected grammar of complaint message #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arvinxx merged 1 commit into from
Jan 6, 2023
Merged

🐛 fix: corrected grammar of complaint message #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/commitlint-plugin/src/rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const emoji: Rule = (parsed) => {
// if don't has gitmoji code or emoji unicode
pass = false;
errorMsg =
'Your commit should start with gitmoji code,please check the emoji code on https://gitmoji.dev/.';
'Your commit should start with gitmoji code. Please check the emoji code on https://gitmoji.dev/.';
}

return [pass, errorMsg];
Expand Down
4 changes: 2 additions & 2 deletions packages/commitlint-plugin/test/rule.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ test('should return error message if commit start without gitmoji code', () => {

expect(value).toEqual([
false,
'Your commit should start with gitmoji code,please check the emoji code on https://gitmoji.dev/.',
'Your commit should start with gitmoji code. Please check the emoji code on https://gitmoji.dev/.',
]);
});

Expand All @@ -25,7 +25,7 @@ describe('commit start with gitmoji code', () => {
const value = emojiRule({ raw: '🤔 chore(scope): test' } as Commit, when);
expect(value).toEqual([
false,
'Your commit should start with gitmoji code,please check the emoji code on https://gitmoji.dev/.',
'Your commit should start with gitmoji code. Please check the emoji code on https://gitmoji.dev/.',
]);
});

Expand Down