Skip to content

Adjust logic for GarbageDisposal in tests to debug Windows strange behaviour #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2022
Merged

Adjust logic for GarbageDisposal in tests to debug Windows strange behaviour #127

merged 3 commits into from
Oct 30, 2022

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Oct 30, 2022 •
edited
Loading

No description provided.

@ascopes ascopes changed the title Adjust logic for GarbageDisposal in tests to debug Windows strange be… Adjust logic for GarbageDisposal in tests to debug Windows strange behaviour Oct 30, 2022
@sonatype-lift
Copy link

sonatype-lift bot commented Oct 30, 2022

⚠️ 3 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@github-actions
Copy link

github-actions bot commented Oct 30, 2022 •
edited
Loading

Test Results

   385 files  +12     385 suites  +12   26m 57s ⏱️ + 9m 33s
8 846 tests +16  8 770 ✔️ +17  76 💤  - 1  0 ❌ ±0 
9 000 runs  +16  8 924 ✔️ +17  76 💤  - 1  0 ❌ ±0 

Results for commit 075f2c0. ± Comparison against base commit 4941479.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022 •
edited
Loading

Codecov Report

Merging #127 (075f2c0) into main (4941479) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   52.72%   52.72%           
=======================================
  Files          65       65           
  Lines        2492     2492           
  Branches      231      231           
=======================================
  Hits         1314     1314           
  Misses       1084     1084           
  Partials       94       94
Impacted Files Coverage Δ
...a/io/github/ascopes/jct/utils/GarbageDisposal.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ascopes ascopes self-assigned this Oct 30, 2022
@ascopes ascopes added bug Something isn't working enhancement Optimisations and internal improvements in the codebase. labels Oct 30, 2022
@ascopes ascopes added this to the 1.0.0 milestone Oct 30, 2022
@ascopes ascopes merged commit 9b9f75f into main Oct 30, 2022
@ascopes ascopes deleted the task/fix-gc-tests-for-windows branch October 30, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ascopes ascopes

Labels

bug Something isn't working enhancement Optimisations and internal improvements in the codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ascopes @codecov-commenter