Skip to content

Conversation

@sohel-79
Copy link
Contributor

@sohel-79 sohel-79 commented Dec 8, 2022

Moved abstract jct compiler out of the impl package #186
also updated API annotation

@codecov-commenter
Copy link

Codecov Report

Merging #187 (b5709e8) into main (9692346) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files          67       67           
  Lines        2467     2467           
  Branches      227      227           
=======================================
  Hits         1455     1455           
  Misses        924      924           
  Partials       88       88           
Impacted Files Coverage Δ
...hub/ascopes/jct/compilers/AbstractJctCompiler.java 52.99% <ø> (ø)
...opes/jct/compilers/javac/JavacJctCompilerImpl.java 85.71% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ascopes ascopes added this to the 1.0.0 milestone Dec 9, 2022
@ascopes ascopes added documentation Improvements or additions to documentation housekeeping labels Dec 9, 2022
@ascopes ascopes linked an issue Dec 9, 2022 that may be closed by this pull request
@ascopes
Copy link
Owner

ascopes commented Dec 9, 2022

LGTM, thanks!

@ascopes ascopes merged commit 300b730 into ascopes:main Dec 9, 2022
@sohel-79 sohel-79 deleted the sohel-79-patch-3 branch December 14, 2022 06:00
@sohel-79 sohel-79 restored the sohel-79-patch-3 branch December 14, 2022 06:00
@sohel-79 sohel-79 deleted the sohel-79-patch-3 branch December 14, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move abstract jct compiler out of the impl package

3 participants