adds two unit tests for JctFileManagerImpl module. #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascopes
reviewed
Jan 8, 2023
...ting/src/test/java/io/github/ascopes/jct/tests/unit/filemanagers/JctFileManagerImplTest.java
Outdated
Show resolved
Hide resolved
ascopes
reviewed
Jan 8, 2023
...ting/src/test/java/io/github/ascopes/jct/tests/unit/filemanagers/JctFileManagerImplTest.java
Outdated
Show resolved
Hide resolved
ascopes
reviewed
Jan 8, 2023
...mpiler-testing/src/test/java/io/github/ascopes/jct/tests/unit/filemanagers/package-info.java
Outdated
Show resolved
Hide resolved
|
I've enabled the CI pipeline runners for you, btw. |
Codecov Report
@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 68.54% 68.54%
=======================================
Files 72 72
Lines 2540 2540
Branches 235 235
=======================================
Hits 1741 1741
Misses 733 733
Partials 66 66 |
ascopes
reviewed
Jan 8, 2023
...ting/src/test/java/io/github/ascopes/jct/tests/unit/filemanagers/JctFileManagerImplTest.java
Outdated
Show resolved
Hide resolved
ascopes
requested changes
Jan 14, 2023
...ting/src/test/java/io/github/ascopes/jct/tests/unit/filemanagers/JctFileManagerImplTest.java
Outdated
Show resolved
Hide resolved
...ting/src/test/java/io/github/ascopes/jct/tests/unit/filemanagers/JctFileManagerImplTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review comments and thank you so much for your patience |
|
@Badrri-Narayanan no worries at all. LGTM. |
ascopes
approved these changes
Jan 14, 2023
…Junit and modifies @DisplayName to be consistent with project style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds two Junit tests for JctFileManagerImpl module. Kindly consider this as my initial draft
related to #219