Skip to content

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Jan 21, 2023

  • Add default tags to run JCT-specific tests -- java-compiler-testing-test and javac-test. This means anyone using JCT can just run ./mvnw test -Dgroup=javac-test if they want to run all of the javac tests but nothing else in their builds.
  • Disable builds if in a GraalVM native image to prevent untested behaviour.
  • Mark the JavacCompilerTest annotation as a TestTemplate to assist IDE support.

- Add default tags to run JCT-specific tests.
- Disable builds if in a GraalVM native image to prevent
  untested behaviour.
- Mark the JavacCompilerTest annotation as a TestTemplate
  to assist IDE support.
@ascopes ascopes force-pushed the task/junit-annotations branch from b82c9dc to 7a44222 Compare January 21, 2023 20:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Merging #275 (b82c9dc) into main (3916c06) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head b82c9dc differs from pull request most recent head 7a44222. Consider uploading reports for the commit 7a44222 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   71.19%   71.43%   +0.24%     
==========================================
  Files          74       75       +1     
  Lines        2562     2591      +29     
  Branches      238      238              
==========================================
+ Hits         1824     1851      +27     
- Misses        671      673       +2     
  Partials       67       67              
Impacted Files Coverage Δ
...opes/jct/compilers/javac/JavacJctCompilerImpl.java 87.50% <0.00%> (-12.50%) ⬇️
...thub/ascopes/jct/junit/JavacCompilersProvider.java 100.00% <0.00%> (ø)
...a/io/github/ascopes/jct/junit/VersionStrategy.java 100.00% <0.00%> (ø)
...b/ascopes/jct/junit/AbstractCompilersProvider.java 96.29% <0.00%> (+0.37%) ⬆️

@github-actions
Copy link

Test Results

  1 159 files  ±0    1 159 suites  ±0   0s ⏱️ ±0s
14 978 tests ±0  14 968 ✔️ ±0  10 💤 ±0  0 ±0 
15 208 runs  ±0  15 198 ✔️ ±0  10 💤 ±0  0 ±0 

Results for commit 7a44222. ± Comparison against base commit 19d187f.

@ascopes ascopes merged commit e68bd75 into main Jan 21, 2023
@ascopes ascopes deleted the task/junit-annotations branch January 21, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants