Skip to content

Add missing AbstractJctCompiler coverage #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Add missing AbstractJctCompiler coverage #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/AbstractJctCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,20 +506,21 @@ protected final A myself() {
*/
protected List<String> buildFlags(JctFlagBuilder flagBuilder) {
return flagBuilder
.annotationProcessorOptions(getAnnotationProcessorOptions())
.showDeprecationWarnings(isShowDeprecationWarnings())
.failOnWarnings(isFailOnWarnings())
.compilerOptions(getCompilerOptions())
.previewFeatures(isPreviewFeatures())
.release(getRelease())
.source(getSource())
.target(getTarget())
.verbose(isVerbose())
.showWarnings(isShowWarnings())
.annotationProcessorOptions(annotationProcessorOptions)
.showDeprecationWarnings(showDeprecationWarnings)
.failOnWarnings(failOnWarnings)
.compilerOptions(compilerOptions)
.previewFeatures(previewFeatures)
.release(release)
.source(source)
.target(target)
.verbose(verbose)
.showWarnings(showWarnings)
.build();
}

@SuppressWarnings("NullableProblems") // https://youtrack.jetbrains.com/issue/IDEA-311124
@SuppressWarnings({"NullableProblems", "ThrowFromFinallyBlock"})
// NullableProblems is needed due to https://youtrack.jetbrains.com/issue/IDEA-311124
private JctCompilation compileInternal(
@WillNotClose Workspace workspace,
@Nullable Collection<String> classNames
Expand All @@ -528,13 +529,27 @@ private JctCompilation compileInternal(
var flagBuilderFactory = getFlagBuilderFactory();
var compilerFactory = getCompilerFactory();
var compilationFactory = getCompilationFactory();
var flags = buildFlags(flagBuilderFactory.createFlagBuilder());
var compiler = compilerFactory.createCompiler();
var fileManager = fileManagerFactory.createFileManager(workspace);

try (var fileManager = fileManagerFactory.createFileManager(workspace)) {
var flags = buildFlags(flagBuilderFactory.createFlagBuilder());
var compiler = compilerFactory.createCompiler();
// Any internal exceptions should be rethrown as a JctCompilerException by the
// compilation factory, so there is nothing else to worry about here.
// Likewise, do not catch IOException on the compilation process, as it may hide
// bugs. Hence, we have to use a try-finally-try-catch-rethrow manually rather than a nice
// try-with-resources. This is kinda crap code, but it prevents reporting errors incorrectly.

try {
return compilationFactory.createCompilation(flags, fileManager, compiler, classNames);
} catch (IOException ex) {
throw new JctCompilerException("Failed to close file manager", ex);
} finally {
try {
fileManager.close();
} catch (IOException ex) {
throw new JctCompilerException(
"Failed to close file manager. This is probably a bug, so please report it.",
ex
);
}
}
}
}
Loading