PathFileObject tests and bugfixes #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascopes
added
bug
- Mark methods in PathFileObject as raising NoSuchFileException rather than FileNotFoundException which was previously incorrect information. - Fix bug where the 'name' of a PathFileObject could previously have been an absolute path if the PathFileObject was initialised with an absolute file path. Now it will match the string representation of the relative path on the object. - Rename getRoot to the clearer 'getRootPath' which is consistent with other method naming in this class. - Update IllegalArgumentException that is thrown if a root path is not absolute so that it conveys the value of the erroneous parameter in the error message. - Implement tests for PathFileObject.
…tion This keeps the exception handling consistent with the handling used elsewhere, since this API relies on the NIO API rather than the IO API for file system access.
…Exception instead. Enables consistency with the rest of the API.
ascopes
force-pushed
the
task/path-file-object-tests
branch
from
5b936c4 to
2c97913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some bugs in PathFileObject
which was previously incorrect information.
if the PathFileObject was initialised with an absolute file path. Now it will match the
string representation of the relative path on the object.
method naming in this class.
so that it conveys the value of the erroneous parameter in the error message.
Implement tests for PathFileObject.
Replace FileNotFoundException in FileBuilderImpl with NoSuchFileException
This keeps the exception handling consistent with the handling used elsewhere,
since this API relies on the NIO API rather than the IO API for file system
access.
Remove a reference to FileNotFoundException in a test, use NoSuchFileException instead.
Enables consistency with the rest of the API.