Fix bug around registering a module in an empty output location. #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was discovered that results in a NoSuchElementException being raised if a user attempts to register a module in an output location that was created without an initial package on a file system to place files in. To fix this bug, a few core functionalities have changed slightly: - JctFileManager can now throw IllegalArgumentException from createEmptyLocation(). This will be thrown if the location is an output location or a module location. - OutputContainerGroupImpl will now raise an IllegalStateException if it detects that the container group has been misconfigured as outlined above. This error will explain how to mitigate the issue. - ContainerGroupRepositoryImpl will now register the path root that resides behind one or more modules being registered to it. This is also covered by the case that will check if no modules were discovered in anything being registered, since this will treat the path as an empty single package root anyway. - ContainerGroupRepositoryImpl will now refuse to create empty locations for output locations, as this would not make sense under the above constraints.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 78.86% 78.84% -0.03%
==========================================
Files 90 90
Lines 2697 2699 +2
Branches 225 225
==========================================
+ Hits 2127 2128 +1
- Misses 514 515 +1
Partials 56 56
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered that results in a NoSuchElementException being raised if a user attempts to register a module in an output location that was created without an initial package on a file system to place files in.
To fix this bug, a few core functionalities have changed slightly: