Fix explicit class handling #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound - Add new method: PathFileObject#getBinaryName - JctCompilationFactoryImpl will now error if no initial compilation units were found with a clearer error message. - JctCompilationFactoryImpl will now error if any of the explicitly provided class names are not found as compilation units. - JctCompilationFactoryImpl will now error if the list of provided class names is non-null but empty.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 78.66% 81.17% +2.51%
==========================================
Files 91 91
Lines 2789 2816 +27
Branches 231 234 +3
==========================================
+ Hits 2194 2286 +92
+ Misses 536 481 -55
+ Partials 59 49 -10
|
- Add test pack for JctCompilationFactoryImpl. - Add new helper test class for Mockito matchers used within collection-like types. - Add a new method TeeWriter#getContent that gets the lines of content within a TeeWriter, as this is easier to stub than #toString due to how Mockito works internally. - Add a new method TeeWriter#wrapOutputStream that wraps a given OutputStream and Charset in an OutputStreamWriter and inserts that into a new TeeWriter that is returned. - Fix regression in JctCompilationFactoryImpl where the locale was not being set during compilations. - Fix bug in JctCompilationFactory where the TeeWriter was not being flushed, so buffered content may not have been written to System.out properly in some edge cases. - Improve performance of JctCompilationFactoryImpl for explicit class name lookup by avoiding creating a distinct collection that is iteratively resized with O(n) space complexity.
ascopes
force-pushed
the
bugfix/354-explicit-classes
branch
from
5e9c1eb to
46781d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix explicit class handling.
were found with a clearer error message.
class names are not found as compilation units.
names is non-null but empty.
collection-like types.
within a TeeWriter, as this is easier to stub than #toString due to
how Mockito works internally.
OutputStream and Charset in an OutputStreamWriter and inserts that
into a new TeeWriter that is returned.
being set during compilations.
so buffered content may not have been written to System.out properly
in some edge cases.
lookup by avoiding creating a distinct collection that is iteratively
resized with O(n) space complexity.
resulted in an exception being raised if annotation processing was not configured in
a very specific way.