Skip to content

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Apr 22, 2023

This refactors out some really annoying code I duplicated in a few places so that it is now reusable.

Need to just verify the rewrites don't impact path matching on Windows (hence the PR to verify first, as I am working on a Linux box).

@ascopes ascopes added testing Improvements to test packs enhancement Optimisations and internal improvements in the codebase. trimming fat labels Apr 22, 2023
@ascopes ascopes self-assigned this Apr 22, 2023
@github-actions
Copy link

github-actions bot commented Apr 22, 2023

Test Results

  2 333 files  +12    2 333 suites  +12   2s ⏱️ ±0s
28 232 tests +72  28 003 ✔️ +72  229 💤 ±0  0 ±0 
28 542 runs  +72  28 313 ✔️ +72  229 💤 ±0  0 ±0 

Results for commit 1ce2ea6. ± Comparison against base commit a029ae9.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #424 (1ce2ea6) into main (a029ae9) will increase coverage by 0.89%.
The diff coverage is 49.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   83.60%   84.50%   +0.89%     
==========================================
  Files          93       93              
  Lines        2971     2968       -3     
  Branches      242      240       -2     
==========================================
+ Hits         2484     2508      +24     
+ Misses        438      411      -27     
  Partials       49       49              
Impacted Files Coverage Δ
...s/jct/assertions/AbstractContainerGroupAssert.java 100.00% <ø> (ø)
...es/jct/assertions/PackageContainerGroupAssert.java 40.42% <0.00%> (+8.75%) ⬆️
...pes/jct/assertions/ModuleContainerGroupAssert.java 37.50% <14.28%> (+17.50%) ⬆️
.../java/io/github/ascopes/jct/utils/StringUtils.java 100.00% <100.00%> (ø)

@ascopes ascopes force-pushed the task/refactor-fuzzy branch from 6be515c to 1ce2ea6 Compare April 22, 2023 10:17
@ascopes ascopes merged commit 945ad31 into main Apr 23, 2023
@ascopes ascopes deleted the task/refactor-fuzzy branch April 23, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Optimisations and internal improvements in the codebase. testing Improvements to test packs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants