Skip to content

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented May 7, 2023

Closes #447.

Renames several places that access container groups to ensure naming of methods matches the naming scheme used in the rest of the API. Existing methods that are poorly named are deprecated for removal in v1.0.0.

Also fixes a bug in fuzzy name matching within JAR files for PackageContainerAssert that I managed to trigger when updating integration tests.

@ascopes ascopes added bug Something isn't working documentation Improvements or additions to documentation housekeeping enhancement Optimisations and internal improvements in the codebase. labels May 7, 2023
@ascopes ascopes added this to the v1.0.0 milestone May 7, 2023
@ascopes ascopes self-assigned this May 7, 2023
@github-actions
Copy link

github-actions bot commented May 7, 2023

Test Results

  2 685 files  ±    0    2 685 suites  ±0   2s ⏱️ -1s
31 503 tests +261  31 208 ✔️ +261  295 💤 ±0  0 ±0 
31 839 runs  +261  31 544 ✔️ +261  295 💤 ±0  0 ±0 

Results for commit e5f1cf0. ± Comparison against base commit 6dec6ac.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Merging #448 (e5f1cf0) into main (6dec6ac) will decrease coverage by 0.05%.
The diff coverage is 78.57%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   85.90%   85.86%   -0.05%     
==========================================
  Files          93       93              
  Lines        2973     2985      +12     
  Branches      240      241       +1     
==========================================
+ Hits         2554     2563       +9     
- Misses        373      374       +1     
- Partials       46       48       +2     
Impacted Files Coverage Δ
...es/jct/assertions/PackageContainerGroupAssert.java 94.73% <50.00%> (-5.27%) ⬇️
...b/ascopes/jct/assertions/JctCompilationAssert.java 100.00% <100.00%> (ø)

@ascopes ascopes merged commit a78f2b7 into main May 7, 2023
@ascopes ascopes deleted the task/GH-447 branch May 7, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement Optimisations and internal improvements in the codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix naming ambiguities in the APIs

2 participants