Skip to content

Request that Sonatype Lift ignore false positives #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2023
Merged

Request that Sonatype Lift ignore false positives #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70db1ff
Request that Sonatype Lift ignore false positives
ascopes May 8, 2023
c2a3255
Ignore JDK-specific warnings in dogfood tests
ascopes May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .lift.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,7 @@ ignoreFiles = "acceptance-tests/**"
# Use JDK 11 to help Sonatype Lift start the default plugins correctly.
jdkVersion = "11"
summaryComments = true
ignoreRules = [
"PATH_TRAVERSAL_IN",
"URLCONNECTION_SSRF_FD",
]
3 changes: 0 additions & 3 deletions ...src/test/java/io/github/ascopes/jct/acceptancetests/dogfood/JctCompilationConfigurer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public class JctCompilationConfigurer implements JctCompilerConfigurer<RuntimeEx
public void configure(JctCompiler<?, ?> compiler) {
compiler
.failOnWarnings(false)
.inheritClassPath(true)
.inheritModulePath(true)
.addCompilerOptions("-implicit:class")
.showWarnings(false) // ignore spam about the testing module being hidden
.locale(Locale.ENGLISH);
}
Expand Down
7 changes: 0 additions & 7 deletions ...s-dogfood/src/test/java/io/github/ascopes/jct/acceptancetests/dogfood/JctDogfoodTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,6 @@ void jctCanCompileItselfAndUnitTestsAsMultiModule(JctCompiler<?, ?> compiler) th
assertThat(compilation)
.isSuccessful();

assertThat(compilation)
.diagnostics()
.warnings()
.filteredOn(diag -> !diag.getCode().equals("compiler.warn.module.not.found"))
.withFailMessage("Expected no warnings (other than module.not.found)")
.isEmpty();

assertThat(compilation)
.classOutputModules()
.satisfies(
Expand Down
1 change: 0 additions & 1 deletion ...compiler-testing/src/main/java/io/github/ascopes/jct/workspaces/impl/FileBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ public ManagedDirectory copiedFromFile(Path file) {
}

@Override
@SuppressWarnings("findsecbugs:URLCONNECTION_SSRF_FD")
public ManagedDirectory copiedFromUrl(URL url) {
return uncheckedIo(() -> createFile(url.openStream()));
}
Expand Down
1 change: 0 additions & 1 deletion ...mpiler-testing/src/main/java/io/github/ascopes/jct/workspaces/impl/TempDirectoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOEx
* environment you are using.
* @return the temporary directory.
*/
@SuppressWarnings("findsecbugs:PATH_TRAVERSAL_IN")
public static TempDirectoryImpl newTempDirectory(String name) {
// TODO(ascopes): are MS-DOS file name length limits a potential issue here?
assertValidRootName(name);
Expand Down