Skip to content

Update memoyfilesystem with URL handling bugfixes #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

Update memoyfilesystem with URL handling bugfixes #465

merged 1 commit into from
May 15, 2023

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented May 15, 2023

Address previously breaking issues in memoryfilesystem regarding URL handling
now that a fix has been released for the library.

This means I can remove some additional logic in JCT that was previously
working around these issues.

Issues fixed:

  • URL protocol handler now will filter by the requested URL scheme correctly.
  • URLs for directories now have a trailing forward slash, so URLClassLoader
    will not try to interpret it as a JAR and immediately ignore any files
    in subdirectories.

@ascopes ascopes added bug Something isn't working maven Changes within Maven manifests trimming fat labels May 15, 2023
@ascopes ascopes self-assigned this May 15, 2023
@ascopes ascopes merged commit e5a4443 into main May 15, 2023
@ascopes ascopes deleted the task/memoryfs-update branch May 15, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ascopes ascopes

Labels

bug Something isn't working maven Changes within Maven manifests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ascopes