Skip to content

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Apr 8, 2025

Prior to #17 the fields of inner errors would be copied into the data field of the outer message, which resulted in error message formatting that appears out of order.

However, with that behavior gone we still want the Fields() function to include fields from inner errors, which is what this commit achieves.

@coveralls
Copy link

coveralls commented Apr 8, 2025

Pull Request Test Coverage Report for Build 14344599729

Details

  • 5 of 11 (45.45%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 64.577%

Changes Missing Coverage Covered Lines Changed/Added Lines %
context.go 0 1 0.0%
errors.go 5 10 50.0%
Totals Coverage Status
Change from base Build 14340657180: -0.7%
Covered Lines: 206
Relevant Lines: 319

💛 - Coveralls

@ronenh ronenh requested a review from gertd April 8, 2025 20:31
@ronenh ronenh merged commit 9d3efaa into main Apr 8, 2025
3 checks passed
@ronenh ronenh deleted the inner-fields branch April 8, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants