Skip to content

Conversation

@brionmario
Copy link
Member

@brionmario brionmario commented Oct 24, 2025

Purpose

This pull request introduces improvements to documentation and refines logic for handling platform-specific flows in the Asgardeo React SDK. The most notable changes include an update to the README.md to recognize contributors, enhanced checks for embedded sign-in flows, and a fix in the provider logic for Asgardeo V2 platform support.

Documentation update:

  • Added a "Contributors" section to README.md to acknowledge project contributors and visually display contributor avatars.

Platform-specific logic improvements:

  • Updated the conditional in AsgardeoReactClient.ts to check that the argument is an object and not empty before executing the embedded sign-in flow for Platform.AsgardeoV2, preventing unintended flow execution.
  • Imported the isEmpty utility from @asgardeo/browser in AsgardeoReactClient.ts to support the improved conditional logic.
  • Fixed the conditional in AsgardeoProvider.tsx so that branding preferences are skipped only for Platform.AsgardeoV2, aligning with platform capabilities and the related issue tracker.

Code cleanup:

  • Removed unused import of Platform from embedded-flow.ts, streamlining the codebase.

Related Issues

Related PRs

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 7f86393 into asgardeo:main Oct 24, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants