fix: SignInButton issue with AsgardeoV2
#217
Merged
+17
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to documentation and refines logic for handling platform-specific flows in the Asgardeo React SDK. The most notable changes include an update to the
README.mdto recognize contributors, enhanced checks for embedded sign-in flows, and a fix in the provider logic for Asgardeo V2 platform support.Documentation update:
README.mdto acknowledge project contributors and visually display contributor avatars.Platform-specific logic improvements:
AsgardeoReactClient.tsto check that the argument is an object and not empty before executing the embedded sign-in flow forPlatform.AsgardeoV2, preventing unintended flow execution.isEmptyutility from@asgardeo/browserinAsgardeoReactClient.tsto support the improved conditional logic.AsgardeoProvider.tsxso that branding preferences are skipped only forPlatform.AsgardeoV2, aligning with platform capabilities and the related issue tracker.Code cleanup:
Platformfromembedded-flow.ts, streamlining the codebase.Related Issues
asgardeo/thunderruntime #212Related PRs
asagrdeo/thundersupport ⚡️ #213Checklist
Security checks