feat(core): add branding #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge branding objects according to priority
modify get request with type and name parameter
merge branding from console, only if its enabled in the console
movinsilva
force-pushed
the
js-ui-core--branding
branch
from
26f7079 to
b47a515
Compare
dasuni-30
reviewed
Apr 26, 2024
dasuni-30
reviewed
Apr 26, 2024
dasuni-30
reviewed
Apr 26, 2024
dasuni-30
reviewed
Apr 26, 2024
dasuni-30
reviewed
Apr 26, 2024
brionmario
reviewed
Apr 29, 2024
| const { | ||
| baseUrl, | ||
| type = BrandingPreferenceTypes.Org, | ||
| name = 'WSO2', |
There was a problem hiding this comment.
Yes
since they are optional properties in the config, added these as a fallback.
brionmario
reviewed
Apr 29, 2024
| * @returns A Promise that resolves to the response from the server. | ||
| * @throws {AsgardeoUIException} If the API call fails or when the response is not successful. | ||
| */ | ||
| export const brandingText = async ( |
There was a problem hiding this comment.
Suggested change
| export const brandingText = async ( | |
| export const getBrandingPreferenceText = async ( |
There was a problem hiding this comment.
Updated with 3951760
brionmario
reviewed
Apr 29, 2024
packages/core/src/api/branding.ts
Outdated
| * @returns {Promise<BrandingPreferenceAPIResponseInterface>} A promise that resolves with the branding preferences. | ||
| * @throws {AsgardeoUIException} If an error occurs while fetching the branding preferences or when the response is unsuccessful. | ||
| */ | ||
| const branding = async (): Promise<BrandingPreferenceAPIResponseInterface> => { |
There was a problem hiding this comment.
Suggested change
| const branding = async (): Promise<BrandingPreferenceAPIResponseInterface> => { | |
| const getBrandingPreference = async (): Promise<BrandingPreferenceAPIResponseInterface> => { |
There was a problem hiding this comment.
Updated with adb5461
dasuni-30
reviewed
Apr 29, 2024
| * under the License. | ||
| */ | ||
|
|
||
| import {AuthClient} from '../auth-client'; |
There was a problem hiding this comment.
Shall we have space after {. Let's check why this is not checked in Eslint?
Suggested change
| import {AuthClient} from '../auth-client'; | |
| import { AuthClient } from '../auth-client'; |
dasuni-30
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues
Related PRs
Checklist
Security checks