Skip to content

Conversation

@basicBrogrammer
Copy link
Contributor

@basicBrogrammer basicBrogrammer commented Apr 30, 2021

Let me know what kind of testing needs to be done and I can see what I can do.

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@zachdaniel
Copy link
Contributor

I think a simple test in filter_test.exs that does something like Ash.Query.filter(Post, fragment("? = ?", post.id, ^post.id) should do it.

@basicBrogrammer
Copy link
Contributor Author

I think a simple test in filter_test.exs that does something like Ash.Query.filter(Post, fragment("? = ?", post.id, ^post.id) should do it.

I couldn't do ID. I got an error about postgrex expecting a binary when it received a string version of the id. So I used the title

@zachdaniel
Copy link
Contributor

Ah, all good. In the future, you can do type(^post.id, :uuid).

@zachdaniel zachdaniel changed the title [BUG] Update split_fragment fix: fix fragment processing broken May 1, 2021
@zachdaniel zachdaniel merged commit 11665e0 into ash-project:master May 1, 2021
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants