Skip to content

refactor: remove references to "side loading" #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2021
Merged

refactor: remove references to "side loading" #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/side_load_test.exs → test/load_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
defmodule AshPostgres.Test.SideLoadTest do
defmodule AshPostgres.Test.LoadTest do
use AshPostgres.RepoCase, async: false
alias AshPostgres.Test.{Api, Comment, Post}

Expand Down Expand Up @@ -44,7 +44,7 @@ defmodule AshPostgres.Test.SideLoadTest do
assert [%Comment{post: %{title: "match"}}] = results
end

test "many_to_many side loads work" do
test "many_to_many loads work" do
source_post =
Post
|> Ash.Changeset.new(%{title: "source"})
Expand All @@ -67,8 +67,8 @@ defmodule AshPostgres.Test.SideLoadTest do
assert %{linked_posts: [%{title: "destination"}]} = results
end

describe "lateral join side loads" do
test "lateral join side loads (loads with limits or offsets) are supported" do
describe "lateral join loads" do
test "lateral join loads (loads with limits or offsets) are supported" do
assert %Post{comments: %Ash.NotLoaded{type: :relationship}} =
post =
Post
Expand Down Expand Up @@ -122,7 +122,7 @@ defmodule AshPostgres.Test.SideLoadTest do
assert [%Post{comments: [%{title: "def"}, %{title: "abc"}]}] = results
end

test "lateral join side loads with many to many relationships are supported" do
test "lateral join loads with many to many relationships are supported" do
source_post =
Post
|> Ash.Changeset.new(%{title: "source"})
Expand Down