Skip to content

respect read action sort if relationship does not specify one #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2025
Merged

respect read action sort if relationship does not specify one #194

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40c2eb7
respect read action sort if relationship does not specify one
barnabasJ Nov 18, 2025
cb7ddc1
remove duplicated unsets
barnabasJ Nov 19, 2025
0c13593
fix: only sort in cases where we should sort
barnabasJ Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/join.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,14 +445,17 @@ defmodule AshSql.Join do
)
end
end)
|> Ash.Query.unset([:sort, :distinct, :select, :limit, :offset])
|> Ash.Query.unset([:distinct, :select, :limit, :offset])
|> handle_attribute_multitenancy(tenant)
|> hydrate_refs(context[:private][:actor])
|> then(fn query ->
if sort? do
Ash.Query.sort(query, relationship.sort)
query
|> Ash.Query.unset(:sort)
|> Ash.Query.sort(relationship.sort || query.sort)
else
Ash.Query.unset(query, :sort)
query
Copy link
Contributor

@zachdaniel zachdaniel Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort? being false means that we aren't in a situation where sorting should happen at all (like exists/2. I think you want to always unset the sort, and then set the sort to relationship.sort || query.sort, and if sort? is false then you just unset it so we don't sort for no reason.

Copy link
Contributor Author

@barnabasJ barnabasJ Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I miss-interpreted what sort? stood for, fixed

|> Ash.Query.unset(:sort)
end
end)
|> set_has_parent_expr_context(relationship)
Expand Down