improvement: replace auto-sync with notice#12
Merged
Conversation
Old code automatically ran `mix usage_rules.sync` after install, forcing the developer to delete AGENTS.md and re-sync. New code eliminates the auto-sync, and instead emits a notice with example commands.
Contributor
|
FWIW you don't have to delete AGENTS.md. There is a flag to make it remove any packages that you leave out from the command. You should never have to delete AGENTS.md. Does that change your thoughts on this PR? |
Contributor
Author
|
Could I somehow pass "sync" arguments during the "install" operation? (ie do install and sync in one command) If that were possible I'd withdraw the PR. FYI the reason I asked for this tweak is that I run usage_rule.install/sync in a bash script (for testing). (My current workaround is to delete AGENTS.md in the script then re-sync.) For interactive use I wouldn't care. |
Contributor
|
We could support a --sync false option...let's go with your PR though. The notice will be a better UX. I will review tomorrow. |
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #11
Old code automatically ran
mix usage_rules.syncafter install, forcing the developer to delete AGENTS.md and re-sync.New code eliminates the auto-sync, and instead emits a notice with example commands.
Contributor checklist
Leave anything that you believe does not apply unchecked.