Feature/refactor #1
Conversation
…ability. - Created iterate and iterate-promise functions as helpers for the others. The iterate is a foreach that also receives a function of "what to do when a value is getted" and "what to do when returning result". That way a filter creates a result array, when the value (boolean) is true then insert current element to result, and at the end return the array. The same for map, but when got a value (any) push it directly to result. Increases the maintainability due to reduce 3 different methods (foreach, map and filter) to a single point of maintenance (iterate). - Simplified the promises to use the callback version, so increases maintainability because is one single point of modification for promise and callback version. - Changed foreach promise test to check result values. - Added foreach test to check result values after timeout to check the "no callback provided" case. - Simplified the logic of the iteration to don't have a previous function call, so the logic is executed always inside next function.
| }); | ||
| }); | ||
|
|
||
| it('should iterate all the elemnts even if no callback is provided', function(done) { |
| it('should iterate all the elemnts even if no callback is provided', function(done) { | ||
| const result = []; | ||
| arrForeach(sampleArr,(el, i, arr, next) => { result.push(el); next(); }); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'setTimeout' is not defined.
|
|
||
| it('should iterate all the elemnts even if no callback is provided', function(done) { | ||
| const result = []; | ||
| arrForeach(sampleArr,(el, i, arr, next) => { result.push(el); next(); }); |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| }); | ||
|
|
||
| it('should iterate all the elemnts even if no callback is provided', function(done) { | ||
| const result = []; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
|
||
| it('should resolve without error', function(done) { | ||
|
|
||
| const result = []; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| @@ -1,46 +1,24 @@ | |||
| const iterate = require('./iterate'); | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| result.push(value); | ||
| } | ||
| }, | ||
| () => result |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| return iterate( | ||
| arr, | ||
| func, | ||
| (value) => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| }); | ||
| } | ||
| }); | ||
| const result = []; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| @@ -1,45 +1,23 @@ | |||
| const iterate = require('./iterate-promise'); | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| } | ||
| return onComplete(); | ||
| } | ||
| func(arr[i], i, arr, (err, data) => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
|
Hi! Sorry about HoundCI issues, I never used that before neither XO (I'm more on the eslint + airbnb + linting in travisCI). Perhaps you can guide me how to get HoundCI happy. |
|
Hi! Thanks for the contribution. It's very old module, was a quick put-together for an internal project which later got ported to Java. So, don't intend to update, will let it be. |
5 participants
Refactor of the code
Objectives
API Changes
There are no breaking changes, so there is retrocompatibility