fix: Enhance C# metrics analyzer for preprocessor directive complexity #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
…reprocessor directives Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the C# metrics analyzer to better handle preprocessor directives (#if/#else/#endif) when calculating cognitive complexity. The enhancement addresses cases where method bodies are split across preprocessor blocks, which previously caused the analyzer to miss complexity patterns.
Key changes:
- Enhanced function body detection to handle preprocessor-split methods
- Added specialized analysis for ERROR nodes and malformed declarations in preprocessor contexts
- Comprehensive test coverage for various preprocessor directive scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/metricsAnalyzer/languages/csharpAnalyzer.ts |
Enhanced the core analyzer with preprocessor support, including new methods for handling fragmented method bodies and complexity detection in ERROR nodes |
src/test/metricsAnalyzer/languages/csharpAnalyzer.test.ts |
Added comprehensive test suite for preprocessor directive scenarios including nested directives, conditional operators, and complex multi-construct cases |
samples/Test.cs |
Added sample code demonstrating preprocessor directive usage that matches the test cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new method for testing and improve the C# metrics analyzer to support complexity analysis specifically for preprocessor directives. This enhancement allows for better evaluation of code complexity in conditional compilation scenarios.
closes #38